Giter VIP home page Giter VIP logo

m365-msteams-northwind-app-samples's Introduction

Teams App Camp

Microsoft Teams App Camp

THIS REPOSITORY HAS MOVED

You can find the released version of App camp at https://aka.ms/app-camp. Thanks!








Contributing

This repository has been archived. Contributions are welcome at the App Camp repo at https://aka.ms/app-camp. Thanks for your interest in Microsoft Teams App Camp!

Trademarks

This project may contain trademarks or logos for projects, products, or services. Authorized use of Microsoft trademarks or logos is subject to and must follow Microsoft's Trademark & Brand Guidelines. Use of Microsoft trademarks or logos in modified versions of this project must not cause confusion or imply Microsoft sponsorship. Any use of third-party trademarks or logos are subject to those third-party's policies.

m365-msteams-northwind-app-samples's People

Contributors

bobgerman avatar dstarr avatar fhinkel avatar girliemac avatar luisefreese avatar microsoftopensource avatar rabwill avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

m365-msteams-northwind-app-samples's Issues

NEW LAB REQUEST: Graph API

Fabian Williams suggested a new lab specifically about the Graph API

This is a great idea IMO and here are some ideas:

  • Proper use of Graph SDK
  • Elevating privilege with app permissions
  • Handling throttling
  • Browsing large datasets by paging
  • Using webhooks / change notifications for bulk data synchronization

Minor issues labs 1-5

Now A01-A03, B01-B04, and "ConfigurableTab" labs.
These are from Waldek and some but not all have been addressed in the update. Need to review and check.
(Thanks @waldekmastykarz)


More issues from @waldekmastykarz

pointed out that azure-ad-jwt hasn't been updated in 4 years; want to find the best approach (Passport?)

For a GET request you don't need to set the content-type header:

TeamsAppCamp1/A01-Start-AAD/server/identityService.js

Line 130 in 8c00ca5

"Content-Type": "application/json",
Also, to be compliant with HTTP/2, all request headers' names should be lowercase (not necessary for Graph at this time but best practice)

In lab A03, you mention to update devDependencies in package.json to add adm-zip, but if you have a lockfile (which is a default these days) if you run npm i, the changes won't be picked up because npm will only install packages from the lockfile, so it would be better to say: run npm i -D adm-zip

Here: https://github.com/OfficeDev/TeamsAppCamp1/blob/main/Labs/Labs-A/Lab-A03.md#step-1-add-a-module-with-teams-helper-functions, the inTeams function is async but there's no need for async really, unless you're going to modify it later on and want to keep the number of steps lower

RE: manifest versions: JS advocates pointed out that it would make sense to maintain the version in package.json and then sync it to the manifest. It's a small detail, but something that would feel natural to JS devs and also allow them to maintain the app version in just one place

Lab 5, Step 2: in the code sample you could skip the if (employee) { check because just above you verified the opposite and redirect to a different page if it's the case, so this extra check is unnecessary:

I just noticed that you didn't commit lock files to the repo. To ensure that this code will run in the future, it would be good to include them. Otherwise, if one of the dependency changes, it could break the whole sample

NEW LAB REQUEST: Multi-tenant

The app in App Camp is already multi-tenant but the labs don't explain how to run it in other tenants. This lab would guide the student through running the Northwind Orders app in any tenant by creating a service principal and getting administrator consent.

infinite login loop in step 1

I followed the steps in A01 but end up with an infinite login loop here. I'm using the admin@ account. It has an employee ID and a manager. Any idea where I went wrong? I started ngrok with out --host-header because I don't have a paid subscription.

Screen Shot 2022-04-19 at 9 26 00 PM

problem with env variable name

While working on the lab I found that "on my PC" :) HOSTNAME is replaced by my real system HOSTNAME.

HOSTNAME variable defined in .env did not overwrite the real HOSTNAME system variable.

The problem disappeared after I changed HOSTNAME=something.ngrok.io to HOSTNAME123=something.ngrok.io and all process.env.HOSTNAME to process.env.HOSTNAME123

Teams Toolkit Compatibility

Following the release of v4 and the general availability of Teams Toolkit at Microsoft Build, it would be great if the samples in the App Camp could be made compatible to be opened in Teams Toolkit, this would enable developers to use the feature sets in the toolkit to be more productive and provide a more consistent approach to app development.

Using the Toolkit could help new developers get up to speed more quickly and reduce the effort required on setup tasks i.e. auth, manifest creation etc.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.