Interface Builder crashes when components are used on Storyboard about ui-fabric-ios HOT 3 CLOSED

I had a second view on the problem and I think the solution is actually add the init(frame:) initializer to the MSButton class. Maybe the second error I reported on this Issue was due to the build not being cleaned. What I just did is:

• Take the demo project where the error is replicated https://github.com/OrlSan/officeuifabric-sb-demo
• Clean the build on Xcode (Command + Shift + K) and close the project
• Change the Podfile source to git to the fork I just did, pointing to the fix-ib-crash-msbutton branch:
  pod 'OfficeUIFabric', :git => 'https://github.com/OrlSan/ui-fabric-ios.git', :branch => 'fix-ib-crash-msbutton'
  This implementation is only adding the init(frame:) initializer. See: OrlSan@06193ae
• Run pod update and open the project again.

After this the application is running as expected (just like before this changes) but the Interface Builder is not crashing and is actually showing the button with the expected MSButton style:

I think this solution might work, so I'd be happy to know your opinion and maybe I can open a PR.

from ui-fabric-ios.

Hi Orlando

Thank you for reporting this issue and doing an investigation. Implementing init(frame:) might be a fix for it and then we will also have to convert init(style:) to a convenience initializer that should call a new init(frame:). You can create a PR for this change or we can fix it ourselves - you choice. Let me know what you decide.

Thanks,
Vlad

from ui-fabric-ios.

Hi Vlad.

I think I can implement the required init(frame:) and also the conversion for the init(style:) initializer. I'll work on this and then can open the PR.

Thank you!

from ui-fabric-ios.