Giter VIP home page Giter VIP logo

ui-fabric-ios's Introduction

DEPRECATED

This repo is no longer supported, please consider using https://aka.ms/fluentui-apple instead.

License

All files on the Office UI Fabric for iOS GitHub repository are subject to the MIT license. Please read the LICENSE file at the root of the project.

Usage of the logos and icons referenced in Office UI Fabric for iOS is subject to the terms of the assets license agreement.

ui-fabric-ios's People

Contributors

harrieshin avatar janc avatar joelklabo avatar jon-schneider avatar lugonzal avatar markavitale avatar nimccard avatar orlsan avatar philworthington avatar rimarsh avatar tom-un avatar vladfilyakov avatar williamado avatar willrichman avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ui-fabric-ios's Issues

UI-Fabric for macOS?

I'm not sure if this is the right place to ask for this, but is UI Fabric for macOS planned any time soon? Thanks

Swift Packages

I was wondering if you plan to make this work with Swift packages.

Binary size increase question

Can I get an idea of how much will increase the final binary size? If you have any example from apps that have already included the library. Thanks.

[Question] MSPopupMenuItem always shows checkmark on press

Hi!

I have a question about how MSPopupMenuItem/MSPopupMenuItemCell works. I'm looking to present a list of options in a MSPopupMenuController, where clicking on each item causes some other UX to present itself (further screens in a navigation controller, etc).

So touching on the items in the list doesn't need to ever show a checkmark. However, it seems baked in by default. After pressing, it sets the item to "selected" and sets the accessType to checkmark.

I don't see any to override this behavior without completely bailing on MSPopupMenuController and using the drawer and building the list myself. Would this project be open to expanding the functionality to support this "list of actions" rather than a "list of items to choose between".

I could be using MSPopupMenuController incorrectly, so please let me know if this incorrect or confusing.

Thanks!

Roadmap

Hi,

Is any roadmap available for the project? I was considering using the SDK in my next project but for that, I need to do some changed and I want to check if those changes are aligned with project evolution.

Thanks

Interface Builder crashes when components are used on Storyboard

Hi!

I'm adding the OfficeUIFabric pod as described on the README.md and trying to use the components included into this library, but the Xcode's Interface Builder designer crashes if I use a custom class for a button changing it to MSButton.

The minimal reproduction of the error is contained on this repository https://github.com/OrlSan/officeuifabric-sb-demo

Although the application is actually compiling and running the Interface Builder is displaying a blank canvas just containing the base UIViewController frames, but nothing else:

Captura de Pantalla 2019-05-22 a la(s) 16 25 04

Xcode is displaying the Issue message Main.storyboard: error: IB Designables: Failed to render and update auto layout status for ViewController (BYZ-38-t0r): The agent crashed

The Diagnostic report found on ~/Library/Logs/DiagnosticReports is pointing the error as the following:

Application Specific Information:
CoreSimulator 587.35 - Device: iPhone 8 (72039265-FC19-42F2-BCF0-99B04E1058F5) - Runtime: iOS 12.2 (16E226) - DeviceType: iPhone 8
/Users/orlando/Desktop/OfficeUIFabric Demo/Pods/OfficeUIFabric/OfficeUIFabric/Controls/MSButton.swift: 27: 12: Fatal error: Use of unimplemented initializer 'init(frame:)' for class 'OfficeUIFabric.MSButton'

The full crash log is here: IBDesignablesAgent-iOS_2019-05-22-161443_d4nger.crash.txt

What I've tried

As fas as I'm understanding the MSButton class (subclass of UIButton) is crashing the designer because the init(frame:) initializer is not implemented. I actually tried to change the source code and added the initializer so the MSButton implementation will include the following:

    @objc public init(style: MSButtonStyle = .secondaryOutline) {
        self.style = style
        super.init(frame: .zero)
        initialize()
    }

    // Added this initializer
    @objc public override init(frame: CGRect) {
        super.init(frame: frame)
        initialize()
    }

    public required init?(coder aDecoder: NSCoder) {
        super.init(coder: aDecoder)
        initialize()
    }

But again Xcode is displaying an empty canvas and the error is Main.storyboard: error: IB Designables: Failed to render and update auto layout status for BNInitialViewController (BYZ-38-t0r): Failed to load designables from path (null)

I don't know if the implementation of the initializer is the correct way to address this issue because the IB is not displaying the canvas anyway. Seems like an issue with the Autolayout resolution or something related.

Additional information

Xcode: Version 10.2.1 (10E1001)
macOS version: macOS Mojave Version 10.14.5
Pod version: OfficeUIFabric (~> 0.2.0)

I appeciate your help on this Issue, and if you have any questions please let me know.

Thanks!

Constants equal Macros

I am not sure why you have so many stars. (c) (@lolgear)

I don't have enough words to express my amusement.

A lot of Constants that grasp into each piece of UI code.
This reminds me about old #define GetHeight(view) view.frame.size.height macros from C.
Do you feel it? It smells, right.
It smells like student spirit.
Really, I am pretty sure that this "library" was done by your students.

P.S.
I am not going to offense students. This post is only for mentors who "accept" this kind of style.

UIView.animate(withDuration: Constants.selectionBarAnimationDuration, delay: 0, options: [.curveEaseOut, .beginFromCurrentState], animations: {

ERROR ITMS-90535: "Unexpected CFBundleExecutable Key

Hi,
I integrated ui-fabric-ios using Carthage github "OfficeDev/ui-fabric-ios" and everything works fine. When I submit my app to TestFlight, I get the error message

ERROR ITMS-90535: "Unexpected CFBundleExecutable Key. The bundle at 'Payload/AeroNavMap.app/Frameworks/OfficeUIFabric.framework/OfficeUIFabricResources.bundle' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue." 

I checked the contents of the OfficeUIFabric.framework and it does contain the executable

Screenshot 2019-06-22 at 16 08 05

All my other 3rd party dependencies work fine. Any idea what could cause this issue?

[Question] Are you guys open to adding screenshots of the elements in the demo to the readme page?

Hello team,

First and foremost ... thanks for releasing this! One of the first ui libraries that I am actually excited to try out and use on iOS. Definitely bookmarked. I've downloaded and tried the demo. I think this project may receive more traction if people saw the various elements available. I have no issue of doing the work if it aligns with what you guys want out of this project. I will simply take screenshots in the app and create a new markdown page or add to the main readme. I am open to the actual look and feel.

Please let me know if you'd like this PR or you have a team working on this already and it is not needed!

Thank you for all of the hard work! I look forward to future updates of this.

Cheers,
Alex

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.