I got a few of these:

ArgumentException: GUID required
Parameter name: guid
Ogxd.ProjectCurator.ProjectCurator.AssertGuidValid (System.String guid) (at ./Library/PackageCache/com.ogxd.project-curator@adc4b63683/Editor/ProjectCurator.cs:181)
Ogxd.ProjectCurator.ProjectCurator.RemoveAssetFromDatabase (System.String guid) (at ./Library/PackageCache/com.ogxd.project-curator@adc4b63683/Editor/ProjectCurator.cs:67)
Ogxd.ProjectCurator.AssetProcessor+<>c__DisplayClass3_0.<OnWillSaveAssets>b__0 () (at ./Library/PackageCache/com.ogxd.project-curator@adc4b63683/Editor/AssetProcessor.cs:39)
Ogxd.ProjectCurator.AssetProcessor.OnUpdate () (at ./Library/PackageCache/com.ogxd.project-curator@adc4b63683/Editor/AssetProcessor.cs:25)
UnityEditor.EditorApplication.Internal_CallUpdateFunctions () (at <88872b21b1e746a7ad699974a2be8304>:0)

My guess is the path exists on save, but no longer exists when the action is dequeued in OnUpdate. Not sure how that could be, but the case should be handled.

If I keep seeing it I'll include more debug info here like logging out the problematic path so I can pinpoint the case.

Perhaps only on empty folder

ProjectCurator: Asset 'Assets/_Game/Config/Graphs/Statuses' is not present in the database
UnityEngine.Debug:LogWarning (object)
Ogxd.ProjectCurator.ProjectCurator:Warn (string) (at ./Library/PackageCache/com.ogxd.project-curator@6a70b7c196/Editor/ProjectCurator.cs:165)
Ogxd.ProjectCurator.ProjectCurator:RemoveAssetFromDatabase (string) (at ./Library/PackageCache/com.ogxd.project-curator@6a70b7c196/Editor/ProjectCurator.cs:96)
Ogxd.ProjectCurator.AssetProcessor:OnWillDeleteAsset (string,UnityEditor.RemoveAssetOptions) (at ./Library/PackageCache/com.ogxd.project-curator@6a70b7c196/Editor/AssetProcessor.cs:64)
UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)

Hello! Thank you for cool plugin. Can you please add LICENSE.meta for LICENSE file to prevent Unity Editor errors?

Asset Packages/com.ogxd.project-curator/LICENSE has no meta file, but it's in an immutable folder. The asset will be ignored.

As of today (and maybe since an update?), AssetDatabase.GetDependencies(string assetPath) collects depencies recursively.
This is an issue because:

• Refreshing referencers does not work properly on asset update
• It takes more time to build the database for no reason
• It uses more memory

Todo

Make use of AssetDatabase.GetDependencies(assetPath, recursive: false)

Currently the database is stored in ProjectSettings which conventionally is checked in to version control. Doing so would lead to many merge conflicts.

I suggest moving it into either UserSettings or Library. I think in this case it might make the most sense to move it to Library since it does not contain "settings" (the only setting is the overlay toggle, which is stored in EditorPrefs).

Thanks for sharing your open source project. It looks like you haven't specified a license.

Some Background

When you make a creative work (which includes code), the work is under exclusive copyright by default. Unless you include a license that specifies otherwise, nobody else can use, copy, distribute, or modify your work without being at risk of take-downs, shake-downs, or litigation. Once the work has other contributors (each a copyright holder), “nobody” starts including you.

choosealicense.com is a great resource to learn about open source software licensing and the MIT License seems to be what most Unity related projects on here are using.

Thanks again,
John

Hey @ogxd, your branch https://github.com/ogxd/project-curator/tree/refactoring is a good change, and I think should be merged as-is.

Would you mind merging it so I can do other fixes on top of it?

Also afterwards it would make sense to tag a release. I'd suggest going to 2.0.0 as this has breaking changes with 1.x.x

Context

Database persists in memory as an array of reference types (AssetInfos), with 2 array for each AssetInfo to keep track of references of dependencies. This is rather simple and straightforward however it has a few drawbacks:

• It relies on Unity serialization/deserialization, which is kind of slow.
• Database is saved as a json file, which is not the most "optimal" format for keeping track of thousands or even hundreds of thousands of assets.
• It produces quite a lot of memory fragmentation due to the number of reference types it represents (1 for AssetInfo, 1 for string guid, 1 for dependency array and 1 for references array. All of this multiplied by the number of assets to keep track of)

Solution

Make AssetInfo an immutable struct and use a GUID type internally. Reference references and dependencies with indexes and ranges. This way AssetInfo is of constant size (blittable) and we can serialize everything in a few blobs. In memory, that would also mean keeping one big chunk instead of thousands of references.

The project freezes the editor when deleting a lot of "not included" assets.
It might have something to do with rebuilding the database upon removal of an asset, for each asset individually?

Versions:
Unity 2019.3.32f1
Project Curator 1.2.0

We're frequently getting these warnings from this project.

Asset 'Assets/_Game/Content/Chronospheres/ChronosphereUtilities/BiomeEquipmentTables/ClockworkTables/ClockworkItemTables/ClockworkItemTable.asset' that depends on 'Assets/_Game/Content/Clockwork/ClockworkItems/PowerCycle/PowerCycle.asset' doesn't have it as a dependency
UnityEngine.Debug:LogWarning (object)
Ogxd.ProjectCurator.ProjectCurator:RemoveAssetFromDatabase (string) (at ./Library/PackageCache/com.ogxd.project-curator@5a5eb9a295/Editor/ProjectCurator.cs:66)
Ogxd.ProjectCurator.AssetProcessor/<>c__DisplayClass3_0:<OnWillSaveAssets>b__0 () (at ./Library/PackageCache/com.ogxd.project-curator@5a5eb9a295/Editor/AssetProcessor.cs:38)
Ogxd.ProjectCurator.AssetProcessor:OnUpdate () (at ./Library/PackageCache/com.ogxd.project-curator@5a5eb9a295/Editor/AssetProcessor.cs:25)
UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

Is there some actionable fix that should be made here? Otherwise I'd suggest only enabling this warning with a compiler symbol like PROJECT_CURATOR_DEBUG, as I'm not sure what we should do about it at our end.

Happy to contribute this change.

Firstly, thank you for this amazing project, it has become an important part of our workflow.

Our team has reported that references are not updated when an asset is renamed.

To reproduce:

1. Open curator window
2. Select asset A that references asset B
3. Rename asset B to "C"
4. Observe that neither B nor C appear in A' references
5. Select asset C and observe that A no longer appears in its "referencers"

Rebuilding the project fixes this problem.

Hi, could you please tag your releases for OpenUPM support? It seems somebody has already added this repo to OpenUPM but it has not been pulled in due to tags being malformed. For compatibility they will need to use the full semver string (i.e. 1.4.0 instead of 1.4).

https://openupm.com/packages/com.ogxd.project-curator/

I'd open a PR but I don't think I can include tags in a PR?