okamototk / jqm-mobile-bookmark-bubble Goto Github PK

Could you explain how is detected window's mobile ? if it's detectable in your library.
Thanks for response

Android2.1でバブルの×アイコンが大きい

iOS 7 has a new "add to home" button - see http://www.mobilexweb.com/blog/safari-ios7-html5-problems-apis-review for more information.

It would be great if this support could be added.

I've tried to have this work, no success though.
Can anyone please instruct me how to use this?

What I tried was to insert this in the HTML head:

also tried to include the other two JavaScript files.
Nothing happens.

Also, is it possible to exclude support for iOS? I already have a working system for iOS.

Curious if there are any plans to add support for chrome browser and it's bookmarking steps?

Steps required are:
– Open web page
– Click the three vertical dots (top corner)
– Click the "Star" icon
– Save bookmark (somewhere). Note: The old option "Save to home screen" is no longer available
– Click the three vertical dots (again)
– Go to bookmarks
– Search for the bookmark
– Hold bookmark pressed for a second
– Click "Add to home screen"

Not sure how you can explain this in a bubble anymore and hopefully we can avoid having to exclude certain browsers.

Android 4.4 support message is not translate in French. Please help us!

0182a4e

Android 4.4 has a much easier way to add to home screen.

You can do it with only two taps as shown below:
http://prntscr.com/3e6i6u

Are there any plans of updating the code to support that ?

I have phone with Android 4.1.2. And below message from bubble is not correct for my phone:
Install app:

1) Tap |,
2) Select "Save to bookmarks",
3) Select "Add to" and then "Home"

Correct message for adding shortcut to home-screen should be like this:
Install app:

1) Add to Bookmarks,
2) Tap and Hold the bookmark,
3) Select "Add Shortcut"

I can check only on Android 4.1.2. But, maybe, this was changed started from Android 4.1. This should be checked.
Will be well to support separate message for Android 4.1 and later. To make this, necessary extend google.bookmarkbubble.Bubble.prototype.build_ function in bookmark.bubble.js.
Old:

               if (this.getAndroidVersion_() < this.getVersion_(3, 0)) {
          bubbleInner.innerHTML = this.msg.android;
               } else {
                  if ((this.getAndroidVersion_() >= this.getVersion_(4, 0)) && this.isMobile_()) {
            bubbleInner.innerHTML = this.msg.android4;
                  } else {
            bubbleInner.innerHTML = this.msg.android3;
                  }
               }

New:

        if (this.getAndroidVersion_() < this.getVersion_(3, 0)) {
            bubbleInner.innerHTML = this.msg.android;
        } else {
            if ((this.getAndroidVersion_() < this.getVersion_(4, 0))) {
                bubbleInner.innerHTML = this.msg.android3;
            } else {
                if ((this.getAndroidVersion_() < this.getVersion_(4, 1)) && this.isMobile_()) {
                    bubbleInner.innerHTML = this.msg.android4;
                } else {
                    bubbleInner.innerHTML = this.msg.android41;
                }
            }
        }

And also add translations for android41 message and change version from 1.1.2 to 1.1.3.

Android4.0のメニューがブラウザ右上(アドレスバーの右)にあるが、下のメニューボタンをタップしろと表示される。

下記の変更を施せばいい感じになるので、Android 4.0を検出するロジックを入れて改善する

//  bubbleInner.style.margin = isIpad ? '0 0 0 200px' : '0 auto';
  bubbleInner.style.margin = isIpad ? '0 0 0 ' +(window.innerWidth - 240) + 'px' : '0 auto';

  if (isIpad || isPlayBook) {
//    arrow.style.WebkitTransform = 'rotate(180deg)';
    arrow.style.WebkitTransform = 'scale(1,-1)';
    arrow.style.top = '-19px';
  } else {
    arrow.style.bottom = '-19px';
  }

Greetings,

Im trying to use this module with newer versions of jquery and jquerymobile ... but didnt work.

It's saids that the method live() dont work. After review jquery docs the method .live() was deprecated and now we can use the method .on()

I changed in the example.js file and didnt work too ... maybe can somebody help me to fix this issue?

Best Regards