[Bug] The cmdheight reset to 1 after SessionLoad about persisted.nvim HOT 12 CLOSED

Emmm.... I raised it too. 😅

from persisted.nvim.

Thank you for raising. Will look into this during the week. I'll be surprised if this is plugin related as we're mostly using core Vim functionality at load.

from persisted.nvim.

Can you reproduce this with a minimal.lua file? I've just tried with my config and I can't reproduce it:

from persisted.nvim.

@olimorris

Notice: When a session saved two or more buffers, cmdheight will be set to 1. If a session saved only 1 buffer, the cmdheight is still be 2.

You should save session with 2 buffers (vsplit or split) to reproduce this issue.

The minimal.lua file.

vim.opt.sessionoptions = { 'curdir', 'folds', 'tabpages', 'winpos' }
vim.opt.cmdheight = 2
vim.opt.rtp:prepend('~/.local/share/nvim/plugins/persisted.nvim/')
require('persisted').setup {}

Open neovim with nvim -u ./minimal.lua.

from persisted.nvim.

@tmpm697 can you raise a new issue. This is not related to this

from persisted.nvim.

@adoyle-h. Struggling to reproduce this now, I've just tried with the following config and two buffers written into a session.

local root = "/tmp/persisted"

-- Set stdpaths to use root dir
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- Bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

vim.opt.sessionoptions = { 'curdir', 'folds', 'tabpages', 'winpos' }
vim.opt.cmdheight = 2

-- Install plugins
local plugins = {
  {
    "olimorris/persisted.nvim",
    config = true
  },
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

Screenshot below:

Can you try with my config above?

from persisted.nvim.

@olimorris You should use :vs or :sp to open two buffers in same screen to reproduce this issue.

You don't need plugin manager to install plugin. Just use git clone <dir> to download plugin. And add the <dir> to vim.opt.rtp.

vim.opt.sessionoptions = { 'curdir', 'folds', 'tabpages', 'winpos' }
vim.opt.cmdheight = 2
vim.opt.rtp:prepend('~/.local/share/nvim/plugins/persisted.nvim/') -- git clone directory
require('persisted').setup {}

This my record.

from persisted.nvim.

Okay sorry. Long day yesterday. So I can recreate this bug without persisted and using native vim commands:

vim.opt.sessionoptions = { 'curdir', 'folds', 'tabpages', 'winpos' }
vim.opt.cmdheight = 2

Creating the session

Sourcing the session

Can you test the same and then I propose one of us raises an issue in Neovim core.

from persisted.nvim.

Yes. I reproduce it with your codes. Thank you so much. @olimorris

from persisted.nvim.

@adoyle-h I've now raised this neovim/neovim#22450

from persisted.nvim.

Haha damn. Who's written the cleaner issue? 🤣🤣🤣

from persisted.nvim.

I think mine is better. I test it with { 'options', 'localoptions' }, and get the same issue.

from persisted.nvim.