Comments (8)
Did you open neovim with an argument? Or just neovim with no file as argument? For the latter, the Session file is crated, for the former not.
from persisted.nvim.
Thanks for raising this and your detailed minimal.lua file. Can confirm I can recreate this so will take a look at this in the coming days.
from persisted.nvim.
@tummetott I've created a new branch, fix/auto-creating-sessions. Could you check it out and test when you get a moment?
from persisted.nvim.
The issue persists. I've tested your branch, deleted the session files, but they are not automatically created. Furthermore, even when simply running nvim
and then closing it, the session files are no longer generated.
from persisted.nvim.
I've misunderstood the initial issue then. Because using your minimal.lua
file, I could open up Neovim in a directory with no session file, execute :q
and see a session appear
from persisted.nvim.
Okay so just pushed a new feature to the branch. By default, no session should be created if autocreate = false
(which it is by default).
from persisted.nvim.
Ok with autocreate = true
, the session file is created. However now I get errors from time to time:
E5108: Error executing lua: ...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:81: attempt to concatenate field 'dir' (a nil value)
stack traceback:
...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:81: in function 'list'
...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:19: in function 'get_last'
...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:74: in function 'load'
In my opinion, introducing a new option called autocreate
might lead to confusion for users. The expected behavior, when setting autosave = true
, is that saving should occur automatically. However, with the proposed autocreate
setting, it implies that saving will only work when both autosave
and autocreate
are set to true.
A more intuitive approach could be to change the behavior as follows: when autosave = true
, session files are always created automatically because the user expects autosave to function seamlessly. If a different behavior is desired, such as saving only when session files were created before explicitly with :SessionSave
, the option value autosave = "known_dir"
(or another suitable name) could be introduced.
from persisted.nvim.
Following your steps to reproduce the bug, the issue comes down to this. If I remove this it means anytime someone opens up Neovim with an argument, it will automatically save the session...potentially overwriting an existing one.
Appreciate I've been dipping into this issue every couple of days and not given it some dedicated time but open to a PR which could resolve it.
from persisted.nvim.
Related Issues (20)
- [Bug]: Getting "Could not find a session for" error on any new git repo or branch I open HOT 3
- [Bug]: Autoload not working HOT 3
- Error when loading session HOT 3
- [Bug] flash of previous buffer session is autorestored HOT 2
- [Feature] Allow loading a session by name HOT 4
- Replace callbacks with user events HOT 30
- Startup time increased dramatically HOT 3
- [Bug] The cmdheight reset to 1 after SessionLoad HOT 12
- [Bug]: Unable to turn off autosaving HOT 6
- `string.gsub(session, save_dir, "")` will fail if special characters are not escaped HOT 3
- [Bug]: sessions dir is empty and nothing opened when :SessionLoad HOT 3
- `autosave` should not fires when opening single file in any directory HOT 3
- [Bug]: SessionSave / SessionLoad not working HOT 8
- [Bug]: Session overwrite when switch via telescope? HOT 15
- [Bug]: Handle interaction with lazy.nvim HOT 1
- [Bug]: howto pin a buffer through sessions switching? HOT 1
- [Bug]: uv_close: Assertion `!uv__is_closing(handle' failed HOT 10
- [Bug]: Telescope extension doesn't work after neovim update HOT 4
- [Bug]: Still running git commands when `use_git_branch=false` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from persisted.nvim.