[Bug]: Autosave Not Triggered Without Existing Session File about persisted.nvim HOT 8 CLOSED

Did you open neovim with an argument? Or just neovim with no file as argument? For the latter, the Session file is crated, for the former not.

from persisted.nvim.

Thanks for raising this and your detailed minimal.lua file. Can confirm I can recreate this so will take a look at this in the coming days.

from persisted.nvim.

@tummetott I've created a new branch, fix/auto-creating-sessions. Could you check it out and test when you get a moment?

from persisted.nvim.

The issue persists. I've tested your branch, deleted the session files, but they are not automatically created. Furthermore, even when simply running nvim and then closing it, the session files are no longer generated.

from persisted.nvim.

I've misunderstood the initial issue then. Because using your minimal.lua file, I could open up Neovim in a directory with no session file, execute :q and see a session appear

from persisted.nvim.

Okay so just pushed a new feature to the branch. By default, no session should be created if autocreate = false (which it is by default).

from persisted.nvim.

Ok with autocreate = true, the session file is created. However now I get errors from time to time:

E5108: Error executing lua: ...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:81: attempt to concatenate field 'dir' (a nil value)
stack traceback:
        ...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:81: in function 'list'
        ...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:19: in function 'get_last'
        ...hare/nvim/lazy/persistence.nvim/lua/persistence/init.lua:74: in function 'load'

In my opinion, introducing a new option called autocreate might lead to confusion for users. The expected behavior, when setting autosave = true, is that saving should occur automatically. However, with the proposed autocreate setting, it implies that saving will only work when both autosave and autocreate are set to true.

A more intuitive approach could be to change the behavior as follows: when autosave = true, session files are always created automatically because the user expects autosave to function seamlessly. If a different behavior is desired, such as saving only when session files were created before explicitly with :SessionSave, the option value autosave = "known_dir" (or another suitable name) could be introduced.

from persisted.nvim.

Following your steps to reproduce the bug, the issue comes down to this. If I remove this it means anytime someone opens up Neovim with an argument, it will automatically save the session...potentially overwriting an existing one.

Appreciate I've been dipping into this issue every couple of days and not given it some dedicated time but open to a PR which could resolve it.

from persisted.nvim.