olmokramer / atom-mark Goto Github PK

Let me know if you want to transfer atom-mark to me. I haven't developed Atom plug-ins before, but I would be happy to test and merge PRs, and that seems like all that would really be required given the modest scope of this package.

Hi @olmokramer maybe it will be much better If the user can change the color of the pin, and also highlight the number line.

As of Atom 0.113:

Uncaught TypeError: Object [object Object] has no method 'removeClassFromLine' 

In Sublime, when you toggle the mark at a new line it moves the mark there rather than turning off the mark at the old location. This saves the user from having to toggle twice to move the mark. Is it possible to add a setting which enables this?

So my keybinding wasn't working because I had "go-to-mark" instead of "goto-mark". The latter is correct but it's inconsistent with "select-to-mark". I'd suggest making "go-to-mark" the official command but aliasing it as "goto-mark" for backward compatibility.

In mark/styles/mark.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor::shadow .gutter .line-number.marked .icon-right => atom-text-editor.editor .gutter .line-number.marked .icon-right

• atom-text-editor::shadow .gutter .line-number.marked .icon-right:before => atom-text-editor.editor .gutter .line-number.marked .icon-right:before

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

In mark\styles\mark.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor::shadow .gutter .line-number.marked .icon-right => atom-text-editor.editor .gutter .line-number.marked .icon-right

• atom-text-editor::shadow .gutter .line-number.marked .icon-right:before => atom-text-editor.editor .gutter .line-number.marked .icon-right:before

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

When I mark:swap to a pinned-line that is not shown in a current view,
its icon disappears.
However it works perfectly, except the icon disappearance.

Atom 1.0.0, mark 1.3.3, Windows8.