omani / go-monero-rpc-client Goto Github PK

View Code? Open in Web Editor NEW

53.0 53.0 16.0 397 KB

A go client for the Monero wallet and daemon RPC

License: MIT License

Go 100.00%

daemon monero rpc wallet

go-monero-rpc-client's Introduction

Hi 👋 My name is Sun

Developer, Freelancer & Solopreneur

🌍 I'm based in Frankfurt, Germany
🧠 I'm a code contributor to various open-source projects.
🚀 In my spare time I work on open-source and my own private projects.
🤝 I work for companies as a registered freelancer. Hire me as a Software Developer or DevOps Engineer.

Profile

I worked for multinational companies (finance, hosting, data centers), including the world's volume-wise largest IXP (Internet Exchange Point) in Frankfurt, Germany. I am fast and efficient.

Experience

DevOps Engineering: 20+ years
Software Development: 10+ years

Expertise

API Development
Datacenter Engineer
Scripting/Automation
Backend Development
Web Application Development
Database Administrator (DBA)
Virtualization and Containerization
Configuration Management and Deployments

Skills

Socials

Badges

My GitHub Stats

Support Me

I accept payments and donations in BTC:

bc1qgezvfp4s0xme8pdv6aaqu9ayfgnv4mejdlv3tx

go-monero-rpc-client's People

Contributors

Stargazers

Watchers

Forkers

rbrunner7 juergenhoetzel leonardochaia bonedaddy jjsteel ness-network cpt-jack-a-castle hansfordj haven-protocol-org g3n3s1sl4b aiyaya188 yag00 phuong39 vonlisboa ronin-dojo ronin-dojo

go-monero-rpc-client's Issues

Fix: sweepAll struct to consider all available flags

there were recent changes to the monero code.

update the sweepall struct to comply to the new flags in https://github.com/monero-project/monero/blob/master/src/wallet/wallet_rpc_server_commands_defs.h#L757

in particular: the subaddr_indices_all flag is currently missing in our code.

Payments field of ResponseGetPayments and ResponseGetBulkPayments should be a slice

Had to fix this to use these methods.

--- a/wallet/structs.go
+++ b/wallet/structs.go
@@ -479,7 +479,7 @@ type RequestGetPayments struct {
 }
 type ResponseGetPayments struct {
        // list of payments
-       payments struct {
+       Payments []struct {
                // Payment ID matching the input parameter.
                PaymentID string `json:"payment_id"`
                // Transaction hash used as the transaction ID.
@@ -511,7 +511,7 @@ type RequestGetBulkPayments struct {
 }
 type ResponseGetBulkPayments struct {
        // List of payments
-       Payments struct {
+       Payments []struct {
                // Payment ID matching one of the input IDs.
                PaymentID string `json:"payment_id"`
                // Transaction hash used as the transaction ID.

Is this still usable and maintained?

I am looking for a Golang rpc client for a project I'm working on right now. Is this still OK to use?

The Payments field of ResponseGetPayments and ResponseGetBulkPayments should be a slice

Had to fix this to use these methods.

--- a/wallet/structs.go
+++ b/wallet/structs.go
@@ -479,7 +479,7 @@ type RequestGetPayments struct {
 }
 type ResponseGetPayments struct {
        // list of payments
-       payments struct {
+       Payments []struct {
                // Payment ID matching the input parameter.
                PaymentID string `json:"payment_id"`
                // Transaction hash used as the transaction ID.
@@ -511,7 +511,7 @@ type RequestGetBulkPayments struct {
 }
 type ResponseGetBulkPayments struct {
        // List of payments
-       Payments struct {
+       Payments []struct {
                // Payment ID matching one of the input IDs.
                PaymentID string `json:"payment_id"`
                // Transaction hash used as the transaction ID.

Zero values are being sent which may not be desired

Take the below example:

package main

import (
	"testing"

	"github.com/leonardochaia/go-monero-rpc-client/wallet"
)

func TestTX(t *testing.T) {
	// Start a wallet client instance
	client := wallet.New(wallet.Config{
		Address: "http://127.0.0.1:18082/json_rpc",
	})
	// get incoming transfers
	resp1, err := client.GetTransfers(&wallet.RequestGetTransfers{
		In:             true,
		FilterByHeight: true,
		MinHeight:      4200,
		// MaxHeight:      21492184123,
	})

	if err != nil {
		t.Fatal(err)
	}

	if len(resp1.In) == 0 {
		t.Log("Expected incoming transfers, got zero")
		t.FailNow()
	}
}

Given that no value is provided for MaxHeight, 0 is being sent, which makes monero-wallet-rpc filter by height < maxHeight which returns no results.

If you provide a huge MaxHeight like the commented line, or if you add omitempty to the struct it works properly.

I propose we add omitempty to all structs that represent incoming parameters, i.e:

type RequestGetTransfers struct {
	// [redacted]
	FilterByHeight bool `json:"filter_by_height,omitempty"`
	// (Optional) Minimum block height to scan for transfers, if filtering by height is enabled.
	MinHeight uint64 `json:"min_height,omitempty"`
	// (Opional) Maximum block height to scan for transfers, if filtering by height is enabled (defaults to max block height).
	MaxHeight uint64 `json:"max_height,omitempty"`
}

What do you guys think? I don't see other workaround other than modifying the library.

Malformatted struct tag on ResponseGetSpendProof

My linter noted this while I was fixing another issue.

--- a/wallet/structs.go
+++ b/wallet/structs.go
@@ -712,7 +712,7 @@ type RequestGetSpendProof struct {
 }
 type ResponseGetSpendProof struct {
        // Spend signature.
-       Signature string `json":signature"`
+       Signature string `json:"signature"`
 }
 
 // CheckSpendProof()