omemo / python-omemo Goto Github PK

Hey fellow maintainers,

just wondering if this project is still maintained from your side as there has not been many communication and updates since around June 2016.

If not, please let me know and we could discuss to transfer ownership for this repo or maybe adding me to the omemo organisation.

Cheers,
René

I'm trying to install python-omemo on debian wheezy via pip

root@localhost:~# pip install python-omemo 
Downloading/unpacking python-omemo
  Could not find any downloads that satisfy the requirement python-omemo
No distributions at all found for python-omemo
Storing complete log in /root/.pip/pip.log

But I get an error 404 response. Do I need to reconfigure pip or is the library removed from pip ?

root@localhost:~# cat .pip/pip.log 
------------------------------------------------------------
/usr/bin/pip run on Mon Jun 26 21:31:34 2017
Downloading/unpacking python-omemo

  Getting page http://pypi.python.org/simple/python-omemo
  Could not fetch URL http://pypi.python.org/simple/python-omemo: HTTP Error 404: Not Found
  Will skip URL http://pypi.python.org/simple/python-omemo when looking for download links for python-omemo
  Getting page http://pypi.python.org/simple/
  URLs to search for versions for python-omemo:
  * http://pypi.python.org/simple/python-omemo/
  Getting page http://pypi.python.org/simple/python-omemo/
  Could not fetch URL http://pypi.python.org/simple/python-omemo/: HTTP Error 404: Not Found
  Will skip URL http://pypi.python.org/simple/python-omemo/ when looking for download links for python-omemo
  Could not find any downloads that satisfy the requirement python-omemo

No distributions at all found for python-omemo

The exception information is the same for pip-2.7 or pip-3.2

Exception information:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/pip/basecommand.py", line 104, in main
    status = self.run(options, args)
  File "/usr/lib/python2.7/dist-packages/pip/commands/install.py", line 245, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/usr/lib/python2.7/dist-packages/pip/req.py", line 978, in prepare_files
    url = finder.find_requirement(req_to_install, upgrade=self.upgrade)
  File "/usr/lib/python2.7/dist-packages/pip/index.py", line 157, in find_requirement
    raise DistributionNotFound('No distributions at all found for %s' % req)
DistributionNotFound: No distributions at all found for python-omemo

Where is the error ?

There is a problem in the code:

• xsf/xeps#894

The issue and the cause is described here: omemo/gajim-omemo#50

Steps to circumvent the problem include:

• rename add_devices to set_devicesbecause this is what the method actually does. Helps to prevent confusion.
• rename add_own_devices to set_own_devices (same reason as above)
• create a new method call add_device(jid, deviceId) (Should not duplicate device ids in the array. Ie treat the array as a set)
• In decrypt_msg call add_device with sender_jid and sid
• Somewhere in init (before we connect to a server) add all recipient_id, device_id combos from the litesessionstore to the device_ids array (basically calling set_devices)

As the package is not available through PyPI, it would be good to go with a shorter version release cycle.
That way, we can at least give users a hint on what version is minimum required.

Can you add the XEP-0384: OMEMO Encryption support?

• https://xmpp.org/extensions/xep-0384.html

And XEP-0454: OMEMO Media sharing:

• https://xmpp.org/extensions/xep-0454.html

Diff Tool:

• 0.3.0 to current: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.3.0.html&newfile=https://xmpp.org/extensions/xep-0384.html
• 0.8.3 to current: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.8.3.html&newfile=https://xmpp.org/extensions/xep-0384.html
• 0.8.2 to 0.8.3: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.8.2.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.8.3.html
• 0.8.1 to 0.8.2: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.8.1.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.8.2.html
• 0.8.0 to 0.8.1: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.8.0.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.8.1.html
• 0.7.0 to 0.8.0: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.7.0.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.8.0.html
• 0.6.0 to 0.7.0: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.6.0.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.7.0.html
• 0.5.0 to 0.6.0: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.5.0.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.6.0.html
• 0.4.0 to 0.5.0: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.4.0.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.5.0.html
• 0.3.0 to 0.4.0: http://www.aptest.com/standards/htmldiff/htmldiff.pl?oldfile=https://xmpp.org/extensions/attic/xep-0384-0.3.0.html&newfile=https://xmpp.org/extensions/attic/xep-0384-0.4.0.html

Whenever i try to encrypt german umlauts, it runs into UnicodeEncodeError.

02/01/2017 22:26:11: stderr: ERR: File "/usr/local/lib/python2.7/dist-packages/omemo/state.py", line 279, in create_msg
02/01/2017 22:26:11: stderr: ERR: (key, iv, payload) = encrypt(plaintext)
02/01/2017 22:26:11: stderr: ERR: File "/usr/local/lib/python2.7/dist-packages/omemo/aes_gcm.py", line 37, in encrypt
02/01/2017 22:26:11: stderr: ERR: encoded_plaintext = padding_add(plaintext).encode()
02/01/2017 22:26:11: stderr: ERR: UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 28: ordinal not in range(128)

Could you add this lib to pypi?