omniflix / omniflixhub Goto Github PK

I try to build the binary and have

verifying github.com/bianjieai/[email protected]: checksum mismatch
	downloaded: h1:ItdjA6AUyt3SjiN1HxD0DH3OkyMZBqKSKSQYFDF3Ue8=
	go.sum:     h1:399lErsTpI+faTerw5Q4OuVlXAmAQSuibVvxHR3C6OY=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

details on ibc-hooks application
https://github.com/cosmos/ibc-apps/blob/main/modules/ibc-hooks/README.md

• ibc packet forward middleware https://github.com/strangelove-ventures/packet-forward-middleware

update marketplace sales royalty distribution to royalty splits instead of creator

do not update royalty splits if the value is nil

in itc module as claims increases for the campaign gas for tx is also increasing a lot due to claims query on claim tx to check campaign reached max claims or not

	claims := k.GetClaims(ctx, campaign.GetId())
	if uint64(len(claims)) >= campaign.MaxAllowedClaims {
		return sdkerrors.Wrapf(types.ErrClaimNotAllowed,
			"max allowed claims reached for this campaign (campaign: %d, maxAllowedClaims: %d).",
			campaign.GetId(),
			campaign.GetMaxAllowedClaims(),
		)
	}

This can be resolved by using a claim counter for each campaign

The params module was deprecated since cosmos-sdk v0.46. The Cosmos SDK has migrated away from x/params for its own modules. Cosmos SDK modules now store their parameters directly in its respective modules. The params module will be removed in v0.48, as mentioned in v0.46 release. It is strongly encouraged to migrate away from x/params before v0.48

• #87
• #88
• #89

https://github.com/cosmos/gaia/blob/main/docs/modules/globalfee.md

https://github.com/cosmos/ibc-apps/tree/main/modules/async-icq

while creating ibc channel using wasm port getting below error

 gRPC call `send_tx_simulate` failed with status: status: Unknown, message: "failed to execute message; message index: 0: route not found to module: wasm: route not found

solution
we should add wasm to ibc router

ibcRouter.AddRoute(wasmtypes.ModuleName, wasm.NewIBCHandler(appKeepers.WasmKeeper, appKeepers.IBCKeeper.ChannelKeeper, appKeepers.IBCKeeper.ChannelKeeper))

Description

I'm writing evidence validation tools for GoN. In task A4&A6, I need to query IBC Denom on Omniflix, but with gRPC Client I can't get the result back.

Query with CLI

Works fine!

> omniflixhubd q onft denom ibc/B9C0497B80973FB67A3000836186317DA046574DEE98D938848C8620AEFE99DA

creator: omniflix1zcpsseay358eu0mw6gdhdpx26q87mp7mx3ksgw
data: '{"community":"Stargaze","discord_handle":"gerathdavid#9809","github_username":"sarsersirsur","irismod:creator":{"value":"6fd11c8958d06fb4f8d6a06c53fca0166f3b007c"},"irismod:description":{"value":"sarsersirsur"},"irismod:mint_restricted":{"value":true},"irismod:name":{"value":"sarsersirsur"},"irismod:schema":{"value":""},"irismod:symbol":{"value":"SSSS"},"irismod:update_restricted":{"value":true},"irismod:uri_hash":{"value":""},"team_name":"0x4S"}'
description: ""
id: ibc/B9C0497B80973FB67A3000836186317DA046574DEE98D938848C8620AEFE99DA
name: ""
preview_uri: ""
schema: ""
symbol: ""
uri: https://github.com/sarsersirsur
uri_hash: ""

Query with gRPC

With golang script, I always get the error rpc error: code = Unimplemented desc = unknown service OmniFlix.onft.v1beta1.Query. Is that because I use the gRPC client incorrectly?

package chain

import (
	"context"
	"encoding/json"
	"fmt"
	nfttypes "github.com/OmniFlix/onft/types"
	"github.com/taramakage/gon-verifier/internal/types"
	"google.golang.org/grpc"
)

type Omniflix struct {
	conn      *grpc.ClientConn
	nftClient nfttypes.QueryClient
}

func NewOmniflix() *Omniflix {
	conn, err := grpc.Dial(
		ChainGRPCIris,
		grpc.WithInsecure(),
		grpc.WithDefaultCallOptions(),
	)
	if err != nil {
		panic(err)
	}

	return &Omniflix{
		conn:      conn,
		nftClient: nfttypes.NewQueryClient(conn),
	}
}

// Basiclly this method dosen't work as expection.
func (o *Omniflix) GetClass(classID string) (*Class, error) {
	req := &nfttypes.QueryDenomRequest{
		DenomId: classID,
	}
        
        // Here i get the error: rpc error: code = Unimplemented desc = unknown service OmniFlix.onft.v1beta1.Query
	resi, err := withGrpcRetry(func() (interface{}, error) {
		return o.nftClient.Denom(context.Background(), req)
	})
	if err != nil {
		return nil, err
	}
	res, ok := resi.(*nfttypes.QueryDenomResponse)
	if !ok {
		return nil, err
	}

	return &Class{
		ID:      res.Denom.Id,
		Name:    res.Denom.Name,
		Schema:  res.Denom.Schema,
		Creator: res.Denom.Creator,
		Uri:     res.Denom.Uri,
		UriHash: res.Denom.UriHash,
		Data:    res.Denom.Data,
	}, nil
}

Version

• onft module: github.com/OmniFlix/onft v0.4.0-gon-rc11
• omniflix version: 0.9.0-gon-test2

• remove dependency with params module
• add UpdateParams message and it's types
• migration part on upgrade handler

update denom messages to accept royalty splits

I'm working with the development teams who are building the Interchain Stack, and I am aware of a security vulnerability in your code. I would like to report it so that we can coordinate patching to protect your chain.

Please reach out to me at [email protected] so that we can coordinate privately. Thanks!

• add update params protos and implement update params msg
• migrate from x/params paramset to module store
• add tests

• remove dependence on params module
• add UpdateParams message
• migration in upgrade handler

https://github.com/cosmos/ibc-go/tree/main/modules/apps/29-fee