omoflop / moreblockpredicates Goto Github PK

View Code? Open in Web Editor NEW

15.0 15.0 1.0 146 KB

does the optifine thing with biome dependant block textures but on fabric so its good

License: Creative Commons Zero v1.0 Universal

Java 100.00%

moreblockpredicates's People

Contributors

Stargazers

Watchers

Forkers

justahuman-xd

moreblockpredicates's Issues

Latest version crashes with Iris

Works fine with just mbp + sodium
latest.log
Great mod btw

[1.19.4, no sodium] Model of placed blocks doesnt change

Fabric Loader: 0.14.21
Fabric API: 0.83.0
MBP: 1.5
(these are the only mods I have installed)

This is the resourcepack i'm using for demonstration
sand-test-mpb.zip

Expected Result:
Sand uses the minecraft:stone model when an air block is above it.

Actual Result:
Falling Sand blocks, Sand items and Sand block particles change to that of stone as expected, but the actual sand block placed in the world does not change.

Log
latest.log

Incompatibility with the Physics Mod

Just wanted you to be made aware that the mod is incompatible with the Physics Mod.
This is the part of the log that seemed to me most relevant:

[00:28:21] [Render thread/INFO]: Instancing error handler class gg.essential.mixins.MixinErrorHandler
[00:28:21] [Render thread/ERROR]: Mixin apply for mod mbp failed mbp.mixins.json:ItemEntityRendererMixin -> net.minecraft.class_916: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException InjectionPoint(Shift)[@At("INVOKE")] on net/minecraft/class_916::beforeRender with priority 1000 cannot inject into net/minecraft/class_916::method_3996(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;I)V merged by net.diebuddies.mixins.MixinItemEntityRenderer with priority 1000 [PREINJECT Applicator Phase -> mbp.mixins.json:ItemEntityRendererMixin -> Prepare Injections ->  -> handler$chh000$beforeRender(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;ILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: InjectionPoint(Shift)[@At("INVOKE")] on net/minecraft/class_916::beforeRender with priority 1000 cannot inject into net/minecraft/class_916::method_3996(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;I)V merged by net.diebuddies.mixins.MixinItemEntityRenderer with priority 1000 [PREINJECT Applicator Phase -> mbp.mixins.json:ItemEntityRendererMixin -> Prepare Injections ->  -> handler$chh000$beforeRender(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;ILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]

Block Land Particles Retain Vanilla Texture

Using the latest version for 1.19.4, when landing on a block the particles shown are of the vanilla texture.

Mixin apply for mod MBP failed causes infinite loading screen

Log: latest.log

Highlighted Log:
[Line 296-297]

[22:19:59] [Render thread/ERROR]: Mixin apply for mod mbp failed mbp.mixins.json:ItemEntityRendererMixin -> net.minecraft.class_916: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException InjectionPoint(Shift)[@At("INVOKE")] on net/minecraft/class_916::beforeRender with priority 1000 cannot inject into net/minecraft/class_916::method_3996(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;I)V merged by net.diebuddies.mixins.MixinItemEntityRenderer with priority 1000 [PREINJECT Applicator Phase -> mbp.mixins.json:ItemEntityRendererMixin -> Prepare Injections ->  -> handler$bod000$beforeRender(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;ILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: InjectionPoint(Shift)[@At("INVOKE")] on net/minecraft/class_916::beforeRender with priority 1000 cannot inject into net/minecraft/class_916::method_3996(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;I)V merged by net.diebuddies.mixins.MixinItemEntityRenderer with priority 1000 [PREINJECT Applicator Phase -> mbp.mixins.json:ItemEntityRendererMixin -> Prepare Injections ->  -> handler$bod000$beforeRender(Lnet/minecraft/class_1542;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;ILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]

[Line 434]

java.util.concurrent.CompletionException: java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_916 failed

[Line 582-597]

Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [mbp.mixins.json:ItemEntityRendererMixin] from phase [DEFAULT] in config [mbp.mixins.json] from mod [mbp] FAILED during APPLY
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638) ~[sponge-mixin-0.10.7+mixin.0.8.4.jar:0.10.7+mixin.0.8.4]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinApplyError(MixinProcessor.java:589) ~[sponge-mixin-0.10.7+mixin.0.8.4.jar:0.10.7+mixin.0.8.4]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:379) ~[sponge-mixin-0.10.7+mixin.0.8.4.jar:0.10.7+mixin.0.8.4]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.10.7+mixin.0.8.4.jar:0.10.7+mixin.0.8.4]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.10.7+mixin.0.8.4.jar:0.10.7+mixin.0.8.4]
	at io.gitlab.jfronny.libjf.unsafe.asm.AsmTransformer.transformClassBytes(AsmTransformer.java:77) ~[libjf-unsafe-v0-2.3.0-6ed46d7c1aedac91.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:247) ~[fabric-loader-0.12.12.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:150) ~[fabric-loader-0.12.12.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:155) ~[fabric-loader-0.12.12.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at net.minecraft.class_5619.<clinit>(class_5619.java:79) ~[client-intermediary.jar:?]
	at net.minecraft.client.render.entity.EntityRenderDispatcher.apply(EntityRenderDispatcher:369) ~[?:?]
	at net.minecraft.resource.SynchronousResourceReloadListener.method_29490(SynchronousResourceReloadListener:15) ~[?:?]
	at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:787) ~[?:?]
	... 113 more

...And much more I guess

Update and questions

Is an update planned ? The mod seems VERY powerful and i would like to use it for one very specific thing on 1.19.3/4.
Does the known issue affect performance ?

iron_block.json
{ "overrides": [ { "when": { "biome": "minecraft:taiga" }, "apply": "minecraft:diamond_block" } ] }
The iron_block item display as diamond_block when I in taiga, but when I placed in taiga biome it still display as iron_block. Is there anything wrong in my json?

Examples for logical operators are unclear

Would it be possible to update the wiki with functional examples of the logical operators?
I've succeeded at getting individual checks to work, but my attempts at using the AND condition have so far resulted in either malformed JSON, or overrides being considered null.

With operator:
obsidian.json
Without operator:
obsidian.json

1.20(.1)?

title

hello omo

you are on T.V.!!!!! https://lambdaurora.dev/optifine_alternatives/#:~:text=More%20Block%20Predicates,Available%20for%3A%201.17

MBP causes the game to not render any blocks that have predicates...

I'll leave the logfile here, I'm on 1.17.1 with the only version of MBP that works for this version of minecraft.

Here is my logfile :

/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/amethyst_block.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/calcite.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/chiseled_sandstone.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/coarse_dirt.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/cobweb.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/cut_sandstone.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/dirt.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/grass_block_side.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/grass_path_side.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/sand.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/sandstone.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/sandstone_bottom.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/sandstone_top.png
/home/lae/.minecraft/resourcepacks/Primordial-Pack-Dev/assets/minecraft/optifine/ctm/misc/warped_nylium_side.png

Incompatible with Motschen's Better Leaves Resource Pack

When More Block Predicates is installed without BetterLeaves resource pack, game launches fine.
When BetterLeaves resource pack is enabled without More Block Predicates installed, game launches fine.
When both are active, game attempts to launch. The program does not stop responding and the process does not exit. However, it stays perpetually on the loading screen.

I've tried this both with ALL my other mods installed and NONE of my other mods installed, and the same issue occurs, so it is definitely a conflict between these two specifically.

Minecraft version 1.19.3 running on Quilt 0.18.8.
No Optifine installed.
Using More Block Predicates 1.4
Using Better Leaves 7.1 (also tested with 7.0, same issues occur)

Unsure if there's anything you or Motschen can do about this conflict, so I'm submitting this issue to both just in case.

Unable to load resourcepack with mbp folder containing a block model override (v1.3)

Log: https://pastebin.com/6txrEtd9

Incompatible with Iris 1.6.2

Description

After seconds of loading, the game quickly pops up and stops without an error log.

Logs

latest.log

Chests?

Hi! I'm trying to make chest variants of different wood types, does this mod allow for editing the vanilla chest?

Incompatible with Nostalgic Tweaks mod

Game crashes on startup when this mod is used with Nostalgic Tweaks mod
https://github.com/Adrenix/Nostalgic-Tweaks

Minecraft version 1.19

Crash report:
crash-2022-07-09_03.57.08-client.txt

Crash message on launcher:
The game crashed whilst initializing game
Error: java.lang.RuntimeException: Could not execute entrypoint stage 'client' due to errors, provided by 'indium'!
Exit Code: -1

Mod does not work with quilt loader

title

Please dual license

The CC0 license retains patent rights, which leads some groups (like the OSI) to not consider it an open source license. Here is a comparison of open source licenses on Wikipedia; I would recommend MIT, but it's entirely up to you.

Uses Fabric internals

MBP uses loader's internal logger here.
This will make the message appear to come from loader, and causes the game to crash on quilt.
All mods should make their own logger, as done in the example mod.

[Request] Rotating Block Models

Would it be possible to implement rotation and uvlock when applying a block model?

Currently, it seems that MBP can only specify which model or models to use and their weight. In vanilla, the blockstates files do this, but they can also rotate the models and lock the texture rotation. This makes it so that you don't need to have 4 or more seperate model files for blocks that have a direction, such as stairs.