ondrejpetrzilka / rock.collections Goto Github PK

m_firstOrderIndex is left in uninitialized state (not -1) when a new instance is created, Initialize is only called when capacity > 0 in constructor, or when adding a new item with null buckets.

The .NET dictionary will simply iterate on the size of the enumerator, but in your case, you check m_firstOrderIndex, which since it is 0 in the uninitialized state, results in a crash trying to get the first element in an empty collection.

var dict = new OrderedDictionary<string,string>();
foreach (var entry in dict) { /* boom */ }

Our fix is just to change the ctor line to:
if (capacity >= 0) Initialize(capacity);

A better fix would preserve your desire for lazy use of memory, and enumerate on the size, similar to the stock .NET.

Hello,

Thank you for your project!

I have some questions.

1. How to access OrderedDictionary using index?
2. How to get index of a Key of OrderedDictionary?

When accessing the last enumerator element using Enumerator.Current I get an exception, because the implementation can not distinguish between valid enumerator at last element and invalid enumerator advanced past the last index.

I have introduced -2 marker to solve this, and now use named const variables for these markers.

I have implemented a fix in koliyo@1cead3d

Only for OrderedDictionary at the moment.