onebeyond / bamboohrbot Goto Github PK

We're using slack webhooks to publish to slack.

However, asl slack states:

Please note, this is a legacy custom integration - an outdated way for teams to integrate with Slack. These integrations lack newer features and they will be deprecated and possibly removed in the future. We do not recommend their use. Instead, we suggest that you check out their replacement: Slack apps.

So we should change how we publish to slack.

When there are no celebrations, the Let's celebrate message is empty. It should either not be published or published with a banner saying that there are no celebrations.

When publishing to slack, we only take into account the day of the week.

eg. if it's Monday, we publish the events for Tuesday. But we don't take into account if the day we're publishing the message or the day that the message refers to is bank holiday.

The publisher method takes care of:

• Mapping the information
• Publishing to slack

For better testing and and consistency, we should split the logic in two different methods:

• One that maps the information from bamboohr to slack messages
• The other one that publishes to slack a specific payload

Detailed Description

As part of the celebration message, we should be able to provide a list of ephemeris, so they are shown along with birthdays and anniversaries.

e.g. 13th September - Programmers day

Possible Implementation

Set a new env variable or file to set date and comment for that date (similar to bamboohr for birthdays)

Detailed Description

A user suggested in this slack thread that it would be interesting to have the possibility to publish the same event in several slack channels.

Context

This feature would be useful so for example, Bank Holidays can be published both in a Company internal channel for the employees and in a slack channel shared with clients, so they are automatically informed about the Company Bank Holidays.

Possible Implementation

Just support an array of webhooks in the env variables.

          Sorry @inigomarquinez my comment was misplaced. The guide I was asking about is related to this environment variables. Where can all these variables be retrieved from?

Originally posted by @totegsito in #21 (comment)

Only a couple of methods have been tested yet.

The test suite should be improved and perhaps the coverage should also be included.

@Betisman and @totegsito suggest publishing an inspiring quote every day along with the celebrations message.

We could use a service like this one