Giter VIP home page Giter VIP logo

Comments (4)

reefland avatar reefland commented on May 29, 2024 1

Thank again for taking the time to respond. I moved the values out into its own file within ArgoCD such as:

  sources:
    - repoURL: https://bjw-s.github.io/helm-charts
      chart: app-template
      targetRevision: 1.3.2
      helm:
        valueFiles:
          - $values/workloads/lidarr/values.yaml
    - repoURL: 'https://github.com/reefland/k3s-argocd.git'
      targetRevision: HEAD
      ref: values

Within the values.yaml renovate hint is not needed...

# https://github.com/onedr0p/containers/pkgs/container/lidarr-develop
image:
  repository: ghcr.io/onedr0p/lidarr-develop
  tag: "1.1.3.2982@sha256:37dff1e762b8c7cb17dc212db95923f8969897f3f401b5f426afdb14ea069dee"
  pullPolicy: IfNotPresent

Dashboard shows it correctly with digest:
image

I can use this pattern for digests.

from home-ops.

onedr0p avatar onedr0p commented on May 29, 2024

Renovate by default can pick up those changes, you shouldn't need # renovate: depName=ghcr.io/onedr0p/lidarr-develop and a regexManager for them.

This is done by ...

...
  "extends": [
...
    "docker:enableMajor",
...
  "helm-values": {
    "fileMatch": ["kubernetes/.+\\.ya?ml$"]
  },
  "kubernetes": {
    "fileMatch": ["kubernetes/.+\\.ya?ml$"]
  },
...

from home-ops.

reefland avatar reefland commented on May 29, 2024

Sorry I was trying to keep it simple... these are part of ArgoCD. I have:

"argocd": {
    "fileMatch": [
      "applications/.+\\.yaml$",
      "workloads/.+\\.yaml$"
    ]
  },

That only picks up the Helm Chart version, it does not pickup the images within the folded YAML. To pick up the images I have to use that renovate hint.

For example with below, it only picks up the Helm chart version 1.3.2, does not see the image below that.

  sources:
    - chart: app-template
      repoURL: https://bjw-s.github.io/helm-charts
      targetRevision: 1.3.2
      helm:
        values: |
          controller:
            # Valid options are deployment, daemonset or statefulset
            type: statefulset
            revisionHistoryLimit: 3

          image:
            repository: ghcr.io/onedr0p/lidarr-develop
            tag: "1.1.3.2982@sha256:37dff1e762b8c7cb17dc212db95923f8969897f3f401b5f426afdb14ea069dee"
            pullPolicy: IfNotPresent

Once I add in the # renovate: datasource=docker depName=ghcr.io/onedr0p/lidarr-develop then renovate usually picks it up. For unknown reason, its not working on these containers but does work on ghcr.io/onedr0p/exportarr.

from home-ops.

onedr0p avatar onedr0p commented on May 29, 2024

I think keeping it simple would be to drop the custom renovate comments and regex manager and use helm-values ? That is unless it doesn't work this way for Argo since it's a multi line string instead of objects...

I'm not sure why it's not working for the other containers outside maybe the digest being pinned or them not adhering to semver.

from home-ops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.