onefangg / pe Goto Github PK

As highlighted:

findCommand returns findCommand back to the parser, but parser returns FindCommand back to CompanyListParser

From the command message, all the keywords (delimited by spaces) inputted "job", "and" etc. don't exceed 30 letters, which would indicate that all role keywords passed in is correct and valid.

Only after removing "engineering", was the command successful. The previous error message did not include a limit on the number of keywords I can pass in, only indicating that it's a character limit

As so:

This makes it confusing to know where a section ends and misleads the users

Coding standards indicate that only American spelling is to be used. Both 'favourite' and 'unfavourite' follow British spelling.

From: link

Activation bar from addFromRole crosses over and stops in the middle of optional condition - this makes it ambiguous on the scope of addFromRole function

Glossary links shown here redirect to github page instead.

This is inconsistent with the established redirect to section on pdf based on Tables of Contents.

And it is inconvenient when users are clicking on links in the pdf without internet connection, or if the webpage is down for other issues.

From the UG: "If only company keywords are entered, companies whose names match any of the given
keywords will be displayed with all their roles",

Since both "Lonesome" and "some random long company" both contain 'some' as a keyword, find should return both, since it indicates that the name must match, and not the individual 'word'.

Can't add phone number country code inside application as shown here. This would be needed as not all companies that the user is searching for would originate from the same country and have same local phone code.

Indicated here on page 4 of DG that:

But following diagram shows ABCCommand referencing add

While inputting command here, it shows the following error message:

For the company and role that I'm editing here:

It doesn't have separation between invalid command message (ie. not following the correct format) and having a message for invalid index.

Some companies have numbers/years in their role title, and it is overly restrictive to indicate that it's an invalid command format.

Before entering command:

After entering command:

No chances in message to indicated that 1) command has been parsed/inputted 2) no message to indicate that address is invalid, and is silently processed.

On Page 7 of the DG, it highlights that:

It implies that the executes() method originates from command.

On Page 8 of the DG,

The execute() method seems to originate from LogicManager instead

"favourite", "unfavourite" is used - but coding standard here that American spelling is to be used as it's meant to be for international audiences

There is no way to find out what is the current window from the command line, only option is to exit, re-run the application, and manually filter the latest deadline in the application and manually estimate the window set.

Dummy report Edited