Giter VIP home page Giter VIP logo

Comments (2)

OneLoneCoder avatar OneLoneCoder commented on August 29, 2024

Hi d0gtail,
That's a really interesting observation. And thanks, because it shows me a location I can make the code clearer. In this instance, all reads of opcodes increment the pc, so the addr_abs is actually set to the correct value. Reading from addr_abs in fetch() does not increment the pc, because this would be very disruptive to program flow :D. Now in the unique circumstances of IMM, I need to increase the pc, so the next opcode can be read from the correct location because its the only address mode that has the actual data as part of the instruction. In the next upload, I'll flesh this out so its more obvious why this is the case.
Thanks!

from olcnes.

d0gtail avatar d0gtail commented on August 29, 2024

Hi David,
thanks for your review of the issue and all the hard work you're pouring in this project. Now I see how addr_abs still points to the right position. At first it looked like the pc increment to the value had to be done in the IMM function but since it's incremented by the read of the opcode all is fine. As you said it's wasn't obvious at the first glance.
Should I close the issue now?
Thanks!

from olcnes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.