onesky / api-library-php5 Goto Github PK

I had an issue that I relied on your exceptions instead of the response of the CURL request. A response code of 400 couldn't be catched because there isn't an exception thrown if it occurs. An exception is only thrown when the result of the CURL request is false (https://github.com/onesky/api-library-php5/blob/master/src/Onesky/Api/Client.php#L360).
It is better to extend this check also with the CURL response code because only the expected response codes should be accepted.

We have done this at https://github.com/partnermarketing/onesky-api-client/commits/master

• Normalize code. (avoid $_vars).
• Add composer.lock to .gitignore.
• Update composer autoload to use PSR-4.

Looks like version 1.0.4 is not on packagist which means you don't have the sync activated.

Could you please activate sync between github and packagist to have all tags automatically available on packagist.

https://packagist.org/packages/onesky/api-library-php5

https://github.com/onesky/api-documentation-platform/blob/master/resources/screenshot.md

Actions to implement:

• Upload

https://github.com/onesky/api-documentation-platform/blob/master/resources/feedback.md

Actions to be implemented:

• List
• show
• create

...because you shouldn't pollute the global namespace. We have done this at https://github.com/partnermarketing/onesky-api-client/commit/bf5f4c9ba5c43de6bc21c993cf3370cf390b68fd

https://github.com/onesky/api-documentation-platform/blob/master/resources/translation.md#export-multilingual-file---export-translations-in-multilingual-files

• Implement multilingual action.

Any chance of a 1.0.6 tag/release?

Raised by @skolodyazhnyy
https://getcomposer.org/doc/02-libraries.md#specifying-the-version

I receive an error message "401 Fail to authorize":

$osaClient = new OneSkyApp\Client;
$osaClient->setApiKey(API_KEY));
$osaClient->setSecret(API_SECRET));
$osaClient->translations('export', array(
'project_id' => $projectId,
'locale' => $locale,
'source_file_name' => $filename
));

Sorry for opening this prematurely, bug was in my code

Please update the Client to get rid of this warning:

Deprecated: curl_setopt(): The usage of the @filename API for file uploading is deprecated. Please use the CURLFile class instead in xxx/OneSky/Api.php on line 306

Thank you!

https://github.com/onesky/api-documentation-platform/blob/master/resources/phrase_collection_attachment.md

Actions to implement:

• List
• Upload
• Download
• Delete

https://github.com/onesky/api-documentation-platform/blob/master/resources/translation.md#app-description---export-translations-of-app-store-description-in-json

• Implement app-descriptions action.

When iI try to

POST /projects/123/phrase-collections

I got this error:

[status] => 400
[message] => Project doesn't belong to phrase collection type

the params I am sending are similar to this:

array(1) {
  ["collections"]=>
  array(16) {
    ["campaign_label.en"]=>
    array(2) {
      ["updated"]=>
      array(1) {
        ["string"]=>
        string(7) "Updated"
      }
      ["new"]=>
      array(1) {
        ["string"]=>
        string(3) "New"
      }
    }
}

What does it mean?

https://github.com/onesky/api-documentation-platform/blob/master/resources/phrase_collection.md

Resource actions to implement on client:

• List
• Show
• Import
• Delete

Add project to: https://scrutinizer-ci.com/

Once you added this project need to do those changes:

On .travis.yml add this:

after_script:
    - wget https://scrutinizer-ci.com/ocular.phar
    - php ocular.phar code-coverage:upload --format=php-clover coverage.clover

Create new file: .scrutinizer.yml

imports:
    - php

tools:
    external_code_coverage:
        timeout: 1200    # Timeout in seconds.

Add code coverage badge to README.md

[![Code Coverage](https://scrutinizer-ci.com/g/onesky/api-library-php5/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/onesky/api-library-php5/?branch=master)

Enable travis for this project so contributors can writ unit tests and ensure they are passing.

Just need to enable the switch on travis.