ongzhihong / pe Goto Github PK

The command is invalid because of a missing space between the parameter and the next one

Differs from UG where it says price must have at most 2 decimal places

In DG it is 10-10000

In UG it is 10-100

you call Ui to print error and it will return an error message to Duke?

I think there might be an error here, it is not going to return the error message to Duke probably

it should be /u not \u

to indicate it is a class it should be :Ui, above it is <>

here it is just Ui

here it is UI

lack of consistency

add user is with [NAME] parameter here

In UG it is [USERNAME]

supposedly 2dp is not allowed, but it is actually allowed when it is small enough

format for sort and filter list of items is underlined randomly in table, when nothing else is and in the program it should not be underlined as well

Does not mention anywhere that sorting is based on price per day only,

You designed it to allow removing transactions in case user change their mind.

It allows removing of finished transactions

This is illogical as users borrowed, paid and you can unpay it when they change their mind afterwards

Can cause inconsistencies in database

Borrowed item from 2016-10-10 to 2020-10-10 and it shows returned oct 10, tried to borrow on oct 10 for 0 days, was rejected.

Tried to borrow on oct 10 for 1 day, approved.

User's item is borrowed for 0 days

seems that the borrowing is coded to be start of the day and

items are only considered returned at the end of the day

and this technically should still result in a gain for user because other users cannot borrow the item on this day then he is essentially losing money when other people can borrow his item for 0 days every day and it actually makes the item unavailable

shld be no more than 20 chars according to the UG for adding users but it is not specified here. User can edit to a longer username and cause problems with the files unknowingly

could standardise the format for inputing parameters

/u for username throughout would be really nice

caused quite abit of inconvenience earlier when i tried to type fast and switch between the commands

Shows acknowledgement for updated item even if the price is exactly the same as before, small improvement to efficiency maybe

0 days duration is allowed for borrowing an item, locking up that item for that day for future borrowing starting from that day.