ontehfritz / csharpmtgdb.info Goto Github PK

Gets a card in a set

Whenever I call GetCard (or any other Get method) using the latest source, it always returns null whenever I pass an id parameter.

Code:

var db = new Db();
Card card = db.GetCard(1);

Debugging shows that it is actually actually using the url 'https://api.mtgdb.info/cards/System.String[]' and silently handles this exception.

Cannot deserialize the current JSON array (e.g. [1,2,3]) into type 'MtgDb.Info.Card' because the type requires a JSON object (e.g. {"name":"value"}) to deserialize correctly.
To fix this error either change the JSON to a JSON object (e.g. {"name":"value"}) or change the deserialized type to an array or a type that implements a collection interface (e.g. ICollection, IList) like List<T> that can be deserialized from a JSON array. JsonArrayAttribute can also be added to the type to force it to deserialize from a JSON array.
Path '', line 1, position 1.

When you have time Gilles that would be awesome! Updates coming Apr 9th
Version 0.2

The following code:

private void button1_Click(object sender, EventArgs e)
{
            var Db = new MtgDb.Info.Driver.Db();
            Card card = Db.GetRandomCard(); <-- Throwed here
            pictureBox1.Load(card.CardImage);
}

Throws unhandled exception randomly.
Exception:
An unhandled exception of type 'Newtonsoft.Json.JsonSerializationException' occurred in Newtonsoft.Json.dll
Additional information: Error converting value {null} to type 'System.DateTime'. Path 'releasedAt', line 1, position 1890.

The API returns empty release dates and the parser can't handle them, am I right?

Also:
< packages>
< package id="MtgDb.Info.Driver" version="0.3" targetFramework="net40" />
< package id="Newtonsoft.Json" version="6.0.2" targetFramework="net40" />
< /packages>

Probably should have a check like this:

if( end < start || start <= 0 )

rather than

if( start > 0 || end > 0 )

to ensure success of the API call.

Side Note: Projects in monodevelop don't seem to be able to load with VS 2010, however vice versa is OK.

Also the C# driver throws exceptions on windows 7:

System.IO.FileNotFoundException: Could not load file or assembly 'MtgDb.Info.Driver, Version=0.1.5176.17133, Culture=en, PublicKeyToken=null' or one of its dependencies. Het systeem kan het opgegeven bestand niet vinden.
File name: 'MtgDb.Info.Driver, Version=0.1.5176.17133, Culture=en, PublicKeyToken=null'

Kudos to: Gilles Van Glabeke

@TheZappa sent you an email :)