onwidget / storybook-amp Goto Github PK

Would be nice to update package.json to support other node versions

Thanks for creating this nice library

I have a question regarding the import of @emotion/styled inside the components

Where is it supposed to comes from I do not see it as peerDeps or deps ?

• storybook-amp/package.json

  Line 46 in a34b6c0

  "dependencies": {

• storybook-amp/package.json

  Line 75 in a34b6c0

  "peerDependencies": {

It creates the following error on my side:

Module not found: Error: Can't resolve '@emotion/styled' in '/Users/XXX/node_modules/storybook-amp/dist/components'
 @ /Users/XXX/node_modules/storybook-amp/dist/components/PanelContent.js 10:37-63

When I add @emotion/styled and @emotion/react as a devDeps it works on my side

Hello there,

First off, I'm so glad I found this addon/decorator. It's fantastic!

I found one issue with it though. It's not compatible with the "addon-a11y" decorator. That decorator uses AXE's plugin. This plugin requires the AXE script to be included in iframes in order to perform the audit. See this rule: https://dequeuniversity.com/rules/axe/3.5/frame-tested?application=axeAPI.

Thank you.

I have this error Cannot read properties of undefined (reading 'isEnabled') when I enable storybook-amp, is it because I use storybook 7 ?

Thank you

Hello!
Just wanted to say that I'm loving your storybook addon so far. I am facing an issue with Chromatic, however, which I am hoping to fix. Do you have some thoughts on a way forward for this? Not sure why I am getting access denied:

Chromatic build is failing because it cannot take a snapshot. Thanks in advance for your help!