ooeyes / tippingover Goto Github PK

Category filtering doesn't currently follow redirects before performing the category check, which is not intuitive and less useful. All category filtering modes should be adapted to follow redirects first before performing the check.

Guessing these were renamed or typoed.

( ! ) Notice: Undefined property: TippingOverConfiguration::$mLateCategoryFilter in extensions/TippingOver/includes/TippingOverConfiguration.php on line 423
Call Stack
#	Time	Memory	Function	Location
8	0.1970	8122040	TippingOverConfiguration->__construct( )	.../WikiTooltips.php:144
9	0.1970	8122616	TippingOverConfiguration->validate( )	.../TippingOverConfiguration.php:289

( ! ) Notice: Undefined property: TippingOverConfiguration::$mEarlyCategoryFilter in extensions/TippingOver/includes/TippingOverConfiguration.php on line 462
Call Stack
#	Time	Memory	Function	Location
8	0.1970	8122040	TippingOverConfiguration->__construct( )	.../WikiTooltips.php:144
9	0.1970	8122616	TippingOverConfiguration->validate( )	.../TippingOverConfiguration.php:289

( ! ) Notice: Undefined property: TippingOverConfiguration::$mExistsCheck in extensions/TippingOver/includes/TippingOverConfiguration.php on line 464
Call Stack
#	Time	Memory	Function	Location
8	0.1970	8122040	TippingOverConfiguration->__construct( )	.../WikiTooltips.php:144
9	0.1970	8122616	TippingOverConfiguration->validate( )	.../TippingOverConfiguration.php:289

( ! ) Notice: Undefined property: TippingOverConfiguration::$enableOnImageLinks in extensions/TippingOver/includes/WikiTooltips.php on line 150
Call Stack
#	Time	Memory	Function	Location
6	0.1968	8114480	Hooks::callHook( )	.../Hooks.php:202
7	0.1969	8118456	WikiTooltips::initializeHooksAndModule( )	.../Hooks.php:174

This is how it looks right now when I remove the title attr with javascript, I don't like having both a title and the tooltip. But if possible it would be nicer if the title could be removed by the extension (only when the tooltip actually exists) and then the tooltip positioned according just to the link and not to the link+title.

Please see https://gitlab.com/hydrawiki/hydra/issues/5086

The tooltip API action is not summarized properly in 1.33

There is a fatal bug in the new 0.62. I reverted TippingOver to 0.61 on Hydra since it was crashing the stack.

ImageMap areas should be able to have tooltips on mouseover: https://stoneshard.gamepedia.com/Stoneshard_Wiki:Community_portal#ImageMaps

If the $id passed into isInCategoryLookup() is a string the loop will continue to +1 until it errors out returning false. Seems like this function should be casting $id to an integer before running the loop.

Looks like TippingOver is not initializing its parser instance properly in all scenarios with a ParserOptions object. So when it attempts to use $this->mOptions it produces a fatal error.

This occurred on Hearthstone wiki on several pages. This example is from the Hunter article.

E_ERROR: Call to a member function getMaxIncludeSize() on a non-object

Sample stack trace
…:replaceVariables called at includes/parser/Parser.php (3139)
…:replaceVariables called at includes/parser/Parser.php (1216)
…er::internalParse called at includes/parser/Parser.php (602)
…ed at extensions/TippingOver/includes/WikiTooltips.php (338)
…ed at extensions/TippingOver/includes/WikiTooltips.php (367)
…ed at extensions/TippingOver/includes/WikiTooltips.php (478)
in WikiTooltips::checkAndAttachTooltip called at ? (?)
in call_user_func_array called at includes/Hooks.php (206)
in Hooks::run called at includes/GlobalFunctions.php (4013)
in wfRunHooks called at includes/Linker.php (252)
in Linker::link called at includes/OutputPage.php (1244)
…ge::addCategoryLinks called at includes/OutputPage.php (1591)
…ddParserOutputNoText called at includes/OutputPage.php (1644)
…utPage::addParserOutput called at includes/Article.php (639)
…rticle::view called at includes/actions/ViewAction.php (44)
in ViewAction::show called at includes/Wiki.php (428)
in MediaWiki::performAction called at includes/Wiki.php (292)
… MediaWiki::performRequest called at includes/Wiki.php (588)
in MediaWiki::main called at includes/Wiki.php (447)
in MediaWiki::run called at index.php (46)

When MediaWiki;To-tooltip-page-name is retrieved, it is done in the user language. It should be done in the wiki's default language.

Copying this from Gitlab

Currently the HTML inserted by TO is something like this:

data-to-id="Invictus_Gaming" data-to-target-title="Invictus Gaming" data-to-can-late-follow="false" data-to-tooltip-title="Tooltip:Invictus Gaming" data-to-is-image="false" data-to-empty-page-name="false" data-to-missing-page="false"

But most of these either are global constants or could be computed easily from global constants. Could these be made to actual global constants and removed from the inline HTML? A huge percentage of the HTML on LoL wiki frontpage is TO attributes, and it's gotten in the way of inclusion size on some of my tournament pages so I had to make a lot of things not be links anymore; also I want to add tooltips for players but can't really do that because of the current inclusion size increase.

This would be a breaking change but it's pretty standard for extension config options to have the name of the extension in them, and also in WikiConfig atm it's really hard to find all of the TO flags because TippingOver isn't in their name.