opcode-open-spring-fest / smartbid Goto Github PK

So, what is it about?

NFT Integration in English Auction Contract

Add NFT Contract Reference:

• Add a reference to the ERC721 contract for the NFTs being auctioned.

Bid Placement with NFT:

• Modifie the placeBid function to accept an additional parameter _tokenId representing the NFT token ID.
• Bidders must send the NFT token they want to bid with as part of the bid.
• Add a check to ensure that the bidder owns the NFT they are bidding with.

Finalizing the Auction:

• Modifie the finalizeAuc function to transfer the NFT to the highest bidder if the auction is not cancelled.
• Use the safeTransferFrom function from the ERC721 contract to transfer the NFT securely.

Implemente ERC721 Receiver:

• Implemente the onERC721Received function as required by the IERC721Receiver interface.
• This function allows the contract to receive NFTs when they are transferred to it.

Code of Conduct

• I agree to follow this project's Code of Conduct

So, what is it about?

Bid Placement Event:

Event: BidPlaced

• Add an event BidPlaced to emit when a bid is placed.
• This allows external systems to listen for bid placements and track auction activity.

Bidder Withdrawal Function:

Withdraw Function:

• Add a withdraw function that allows bidders to withdraw their bids if the auction is cancelled.
• Bidders can call this function to retrieve their bid amount if the auction is cancelled or they are not the highest bidder.

Code of Conduct

• I agree to follow this project's Code of Conduct

So, what is it about?

Notice: I will accept pr only when you have resolved a significant amount of problem to reduce the gas use(i.e significant amount of decrease in gas utilization) and have a good idea for security enhancement.

Gas Optimization:

Use of uint:

• Utilized uint instead of uint256 for gas savings, optimizing storage usage.

Compact Data Structures:

• Minimized storage usage where possible by using compact data structures, such as using uint instead of larger data types.

Security Enhancements:

Input Validation:

• Ensured that all user inputs are properly validated to prevent vulnerabilities such as reentrancy and denial-of-service attacks.
• Utilized require statements for input validation to revert transactions with invalid inputs, enhancing security and robustness.

Code of Conduct

• I agree to follow this project's Code of Conduct