Giter VIP home page Giter VIP logo

Comments (8)

askpt avatar askpt commented on June 12, 2024 1

@toddbaert and @beeme1mr it seems my PR didn't fix the issue. Could you please reopen this task?

from dotnet-sdk.

beeme1mr avatar beeme1mr commented on June 12, 2024 1

I'll submit a request to add the domain.

from dotnet-sdk.

beeme1mr avatar beeme1mr commented on June 12, 2024 1

NuGet/NuGetGallery#9778

from dotnet-sdk.

askpt avatar askpt commented on June 12, 2024 1

As suspected, the HTML is not rendered correctly. We need to revisit this issue to fix them: https://www.nuget.org/packages/OpenFeature

from dotnet-sdk.

toddbaert avatar toddbaert commented on June 12, 2024 1

As suspected, the HTML is not rendered correctly. We need to revisit this issue to fix them: https://www.nuget.org/packages/OpenFeature

😩

from dotnet-sdk.

askpt avatar askpt commented on June 12, 2024

I was reading this article and it seems we have some badges that are not in the Nuget whitelist: https://learn.microsoft.com/en-us/NuGet/nuget-org/package-readme-on-nuget-org#allowed-domains-for-images-and-badges

Since I am not the package owner, it is hard to understand what is going on under the hood. Could someone help me with this bit here?
@beeme1mr @toddbaert

from dotnet-sdk.

beeme1mr avatar beeme1mr commented on June 12, 2024

Hey @askpt, here's what I discovered. First, the readme isn't live on NuGet yet because we haven't released an update. We were waiting for support for events before releasing an update. That feature was just added, so a release should happen soon.

I also spent some time looking into the markdown restrictions that NuGet has. Unfortunately, they don't support some of the HTML elements we use and they're rendered as plain text. Here's a GitHub issue that shows all the missing features. It also looks like https://bestpractices.coreinfrastructure.org/projects/6250/badge will be blocked but the NuGet team has a process to get a new domain added to their allow list.

I think the biggest issue is the lack of HTML support in NuGet. We may want to write a script that strips HTML. We already have x-hide-in-docs-start and e x-hide-in-docs-end tags that could be used to remove unwanted content.

What do you think @askpt? FYI @toddbaert

from dotnet-sdk.

askpt avatar askpt commented on June 12, 2024

Sorry @beeme1mr got confused between the contrib and SDK packages. I thought there was a new version for the SDK with the PR that introduces the NuGet feature.
In relation to your point, might be useful looking into a new tag just to show/hide when published to the NuGet.
For the badges, you're right. Might be worth trying to have the other team to add the domains to the whitelist.

from dotnet-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.