Comments (6)
Well it's not threadsafe for one, so if you called in different threads at the same time, I'm not really sure what would happen.
Should you call it multiple times in a single thread? Well if you call it with the same global args each time, maybe nothing bad would happen, especially if you didn't create the environment until after you called it multiple times.
So you said you inited it multiple times for train/test, which means that, if both are in the same process, it's likely either your test environment is the same as your train environment or vice versa since it is using global state (for instance USE_HIGH_DIF
). If that's not an issue for you, carry on. If it is an issue, I'd recommend running two different processes. You can even isolate just the environment in a subprocess, like how SubprocVecEnv works, though I don't think we have anything that does that currently.
from coinrun.
Thanks, I was re-initing Coinrun when switching b/w train and test to have the right global state, but you're right thread safety might be a problem. I will try isolating them within separate sub-processes, thanks for the tip!
from coinrun.
I wrote a quick wrapper to wrap a coinrun env inside a subprocess (pretty similar to SubprocVecEnv
). https://gist.github.com/ankeshanand/24d6f45d17cc44a9e0c9d71a636d537e
from coinrun.
Nice! Is there a reason it doesn't just use SubprocVecEnv?
from coinrun.
This is pretty similar to SubprocVecEnv
albeit some minor differences.
From what I got, SubprocVecEnv
expects a list of env_fn
s and converts them into a VecEnv
. In this case, we already have a VecEnv
(and thus don't need the unsqueeze when doing step) that we want to wrap in a subprocess.
from coinrun.
Oh right, unfortunate. There's some functionality in the multiprocessing
module to do some of this already, but it seems to not handle properties well at the very least.
from coinrun.
Related Issues (20)
- Library missing HOT 1
- How To Use HOT 14
- Easy Way to Control the Procedural Generation HOT 1
- env can not set seed to produce the same env or bug?
- trouble with fetching the logs HOT 2
- How to check Done/Termination condition in the Scalarised version of Coinrun HOT 1
- why the next_state never changes? HOT 4
- Results HOT 2
- Tensorboard HOT 1
- AttributeError: 'CoinRunVecEnv' object has no attribute 'spec' HOT 4
- Environment Make Error 1 HOT 3
- How to reset the environment? HOT 1
- Not working on Windows 10 HOT 3
- Simulating deterministic resets for a single environment HOT 2
- High variance in mean_score during test HOT 1
- batch norm always has is_training = True HOT 2
- How many distinguished environments do you use in evaluation? HOT 1
- Test level generation HOT 1
- Does not compile on the new Apple Silicon - M1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coinrun.