2.0.0:
https://zenodo.org/record/1194600

Concept doi:
https://doi.org/10.5281/zenodo.1194599

Hector added a number of tests using its R wrapper.

We should add these too (or some of them).

Pinging @cahartin, @bpbond, @rplzzz, and @pralitp

Could you please check if you're ok with how we link to 'core' Hector in the Readme, would you for example like links to your personal pages or anything? Should we add something like "When using Hector please cite"?

Hector is developing a new R interface (JGCRI/hector#246)

Pyhector should provide similar functionality.

Might be an opportunity to switch to using pybind

Thoughts, @swillner?

#20

But not predictable ...

pytest tests/test_pyhector.py::test_output_variables

================ test session starts ================
platform linux -- Python 3.5.3, pytest-3.3.2, py-1.5.2, pluggy-0.6.0
rootdir: /home/robert/openclimatedata/pyhector, inifile: setup.cfg
plugins: cov-2.5.1
collected 1 item

tests/test_pyhector.py F

===================== FAILURES
___________ test_output_variables

    def test_output_variables():
        results = pyhector.run(rcp26)
        assert len(results.columns) == 3
>       results = pyhector.run(rcp26, outputs="all")

tests/test_pyhector.py:74:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pyhector/__init__.py:414: in run
    h.run()
pyhector/__init__.py:134: in run
    self._check(self.__run_size)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <pyhector.Hector object at 0x7f3e03beb828>, v = -1

    def _check(self, v):
        if v < 0:
>           raise HectorException(_lib.hector_get_last_error())
E           pyhector.HectorException: b'Assertion failed: units mismatch'

pyhector/__init__.py:129: HectorException
============= 1 failed in 0.46 seconds ===============================

Options:

Python-Git-Version

https://github.com/aebrahim/python-git-version

Python-Versioneer

This looks good:

This is a tool for managing a recorded version number in distutils-based python projects. The goal is to remove the tedious and error-prone "update the embedded version string" step from your release process. Making a new release should be as easy as recording a new tag in your version-control system, and maybe making new tarballs.

https://github.com/warner/python-versioneer

Stackoverflow Discussion

http://stackoverflow.com/questions/17791481/creating-a-version-attribute-for-python-packages-without-getting-into-troubl

• variables -> output
• update binder badge to beta

This line of code is failing to compile:

array.reset(new py::array_t<double>{{values.size()}, data, handle});

I don't know enough about PyBind to figure it out.

clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -iwithsysroot/System/Library/Frameworks/System.framework/PrivateHeaders -iwithsysroot/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/Headers -arch arm64 -arch x86_64 -Werror=implicit-function-declaration -Iinclude -Ihector/inst/include -I/Users/james/pyhector/venv/lib/python3.8/site-packages/pybind11/include -I/Users/james/pyhector/venv/lib/python3.8/site-packages/pybind11/include -I/Users/james/pyhector/venv/include -I/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/include/python3.8 -c src/Observable.cpp -o build/temp.macosx-10.14-arm64-3.8/src/Observable.o -std=c++11 src/Observable.cpp:87:42: error: non-constant-expression cannot be narrowed from type 'std::vector<double>::size_type' (aka 'unsigned long') to 'pybind11::ssize_t' (aka 'long') in initializer list [-Wc++11-narrowing] array.reset(new py::array_t<double>{{values.size()}, data, handle}); ^~~~~~~~~~~~~ src/Observable.cpp:87:42: note: insert an explicit cast to silence this issue array.reset(new py::array_t<double>{{values.size()}, data, handle}); ^~~~~~~~~~~~~ static_cast<ssize_t>( ) src/Observable.cpp:87:41: warning: braces around scalar initializer [-Wbraced-scalar-init] array.reset(new py::array_t<double>{{values.size()}, data, handle}); ^~~~~~~~~~~~~~~ 1 warning and 1 error generated. error: command 'clang' failed with exit status 1

I am unable to run because the init file is referencing ._bindings which can't be found.

Hi,

I am trying to install pyhector on my mac OS X 10.11. I'm having some issues, see below. It's not able to find emplace_back and std::stop, plus the "error: command 'usr/bin/clang' failed with exit status 1". Googling around, it looked like maybe this is something related to libstdc++, but I couldn't figure out how to deal with it. Any help appreciated, thanks!

H0=35.0,pptv ; preindustrial concentration, pptv

See also JGCRI/hector#79

• requires adding a field 'unit' to config object

Do we need changes on the C++ side, @swillner? Or is this ignored anyway? We could also compare with an expected unit on the Python side if we wanted ...

A "how to" should be part of the documentation.

cc @cahartin

On a clean checkout I get logging output from Hector, not sure whether it's a change here, upstream, or in hector-wrapper.

• review various setup and config scripts
• pin dependencies (pandas, numpy)

https://github.com/openclimatedata/pyhector/actions/runs/1688893551

RELEASING.md?

3.5+ should be enough ...

Check whether everything in JGCRI/hector@93efff3...1c9da2e is covered in Pyhector rc2.0.0

Once Beta release milestone done.

They shouldn't be in the same directory as emissions probably.

Check startDate behaviour when updating to Hector >3.0

JGCRI/hector#604

See

• finish #5
• include Binder button

Support for the HCL syntax in GitHub Actions will be deprecated on September 30, 2019.

https://packaging.python.org/guides/migrating-to-pypi-org/#uploading

https://github.com/JGCRI/hector/releases/tag/v2.3.0

JGCRI/hector#289

The following output variables fail with something like

PyHectorException: b'Assertion failed: Date required for atmospheric CH4'

• OH.TAU_OH
• ozone.O3
• N2O.N2O
• CH4.CH4

Can we test this (in a fork?) with Test-PyPI?

Shorter, consistent names, e.g.

Maybe:
"temperature.Tgav" => "Surface_Temp_Global"

"simpleNbox.Ca" => "Conc_CO2"
"HFC227ea_halocarbon.hc_concentration" => "Conc_HFC227ea"

"forcing.Ftot" => "Forcing_Total"
"forcing.FCO2" => "Forcing_CO2"

Upper case desirable for standing out in Pandas DataFrames.
Camelcase oder under scores?

Could we use something like https://github.com/smessmer/gitversion to expose the hector-wrapper version/git commit and make it readable from Pyhector, @swillner ?

To enable something like

pyhector.__hector_wrapper_version__

to work like

pyhector.__version__

I think "hector_version" got accidentally removed here:

ead5e82#diff-1dd21aff688f4e082b405718978ac463L35