Giter VIP home page Giter VIP logo

Comments (3)

WendyStarfall avatar WendyStarfall commented on July 18, 2024

The menu closes if touching any of the buttons which is fine enough for me personally. I've been on the leash and couldn't possibly fix this without breaking stuff elsewhere, see #29

I say it again here: If we get a kickass, rock solid Real Leash integration with perfect menu overhaul I'm more than grateful and willing to pull it.

from opencollar.

KaroWeirsider avatar KaroWeirsider commented on July 18, 2024

This looks like it requires two changes to OpenCollar - Leash.

The first would be to prevent the Leash Menu from reopening. beginning at line 744:
else if (sVal == "") // no parameters were passed
{
DisplayTargetMenu(kMessageID, iAuth, SENSORMODE_FIND_TARGET_FOR_POST_MENU);
}
would become:
else if (sVal == "") // no parameters were passed
{
DisplayTargetMenu(kMessageID, iAuth, SENSORMODE_FIND_TARGET_FOR_POST_MENU);
g_iReturnMenu = FALSE;
}

The second change is actually appears to be a separate bug being once you are in the Post selection menu, the "⏏" button does not work (before and after the first change). The fix for this is to change what is now line 932 due to the above insertion:
if (!g_iReturnMenu) return;
becomes
if (g_iReturnMenu) return;

from opencollar.

KaroWeirsider avatar KaroWeirsider commented on July 18, 2024

When testing the rest of the Leash menu buttons, I found some were acting similar to the Post menu button. I understand if you feel it would be best to leave this for Open Collar 4.0.
If you want to implement this in pre 4.0, I believe the following will make everything work. (this supersedes the
comments made in the previous post)

Add g_iReturnMenu = FALSE; immediately following Line 704
DisplayTargetMenu(kMessageID, iAuth, SENSORMODE_FIND_TARGET_FOR_LEASH_MENU);
g_iReturnMenu = FALSE; //Prevents the Leash Menu from being re-displayed

Add g_iReturnMenu = FALSE; immediately following what is now Line 722
DisplayTargetMenu(kMessageID, iAuth, SENSORMODE_FIND_TARGET_FOR_FOLLOW_MENU);
g_iReturnMenu = FALSE; //Prevents the Leash Menu from being re-displayed

Add g_iReturnMenu = FALSE; immediately following what is now Line 748
DisplayTargetMenu(kMessageID, iAuth, SENSORMODE_FIND_TARGET_FOR_POST_MENU);
g_iReturnMenu = FALSE; //Prevents the Leash Menu from being re-displayed

The following is so the "⏏" button will function properly.
Change if (!g_iReturnMenu) return;
to if (g_iReturnMenu) return;
on what are now the following lines:
919
929
934

from opencollar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.