opencollar / opencollar Goto Github PK

I have noticed in 3 different avatars, over several OC update versions from 3.8 to 3.916 that using RLV to restrict inventory on OpenCollar in Singularity Viewer causes the avatar to be immediately logged out of world.

If we runaway, the bell (if present in the specific design) shows up even if it was hidden before. A runaway shouldn't cause cosmetic alterations.

98 list lButtons = ["List Words", "Clear All", "Say Penance"];
.....
.....
457 else if(sMessage == "Clear ALL") UserCommand(iAuth, "badwords clearall", kAv);

From Eve Keneinan: This is a bug in 3.930 and 3.935. It is the subhug animation. The time, if set to greater than 20 seconds, defaults to 20 seconds regardless of the setting. It can be set to 10 seconds and none of the other couples anims do this. I've tried it on two collars so far. If anyone can set their subhug on 60 seconds and check if it ends after only 20, we can confirm more widely.

integer MinMaxUnscaled(vector vSize, float fScale)
{
if (fScale < 1.0)
{
if (vSize.x <= 0.01)
return TRUE;
if (vSize.y <= 0.01)
return TRUE;
if (vSize.z <= 0.01)
return TRUE;
}
else
{
if (vSize.x >= 10.0)
return TRUE;
if (vSize.x >= 10.0) <<<<< this is correct? may be vSize.y ??
return TRUE;
if (vSize.x >= 10.0) <<<<< this is correct? may be vSize.z ??
return TRUE;
}
return FALSE;
}

integer MinMaxScaled(vector vSize, float fScale)
{
if (fScale < 1.0)
{
if (vSize.x < 0.01)
return TRUE;
if (vSize.y < 0.01)
return TRUE;
if (vSize.z < 0.01)
return TRUE;
}
else
{
if (vSize.x > 10.0)
return TRUE;
if (vSize.x > 10.0) <<<<< this is correct? may be vSize.y ??
return TRUE;
if (vSize.x > 10.0) <<<<< this is correct? may be vSize.z ??
return TRUE;
}
return FALSE;
}

Reported by Shana Deed, in-world.

In the manual, it is described that it possible for a Primary Owner to force return the key, if someone else has taken them.
However, when my Master tries that, the nothings happens.
Although the collar is open for him, it is locked to the wearer (in this case, me).
The only way that seems to return the keys, is to turn the AddOn off and then back on.

Also, when you use the Timer AddOn to automatically return the keys, nothing happens either.
When you try to enable the option that returns the keys, the nothing happens, and the collar menu doesn't come back.

Right after update (collar is still on the ground), the version reported by the Get Version button in Help/About reports the previous version. This clears up after the update script is reset, so I think it must be that the update script begins to run or is already running before the ~version notecard is updated, and the script doesn't reset to account for the changed notecard.

Just a minor thing, really.

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
Rez the 'Grabby Post' that is sent to your inventory by the button "give Post" in the Leash menu. (Or just hit Rez Post in the same menu.)
Touch it. Select Scan in the dialog menu.

What is the expected output?
A list in the dialog of found avies nearby.

What do you see instead?
No avies listed.

What version of the collar (or other item) are you using?
3.931

Please provide any additional information below.

• The version of 3.2 in the script's name suggests this script hasn't been updated in recent versions.
• A ping is sent (in MassPing(), verified), but I haven't been able to find the collar script that should respond to this ping. If this feature was deliberately removed, I think this script in the post should be removed.
• The script uses variable LISTEN as a boolean (TRUE/FALSE) and as an integer (listen handle). As long as the listener this integer records is always the first listener activated, it will work. In other words, current algorithm protects this unorthodoxed use of the variable. I would advise to straighten this out (if the script is kept, see above).

How to reproduce

• Set up badwords addon with more than one badword (different effects when you use odd or even numbers of badwords!)
• make a dump of the settings and put them into defaultsettings NC.
  • this is the line I use (dump, with 3 badwords)
    User_badwords=badwordson~true~badwords~test-badword~testword2~testword3~penance~tis 's the testpenance!
• Now reset scripts.
• you may check badwords and penance from within the badwords-addons menu

Debugging

Starting here, https://github.com/OpenCollar/OpenCollarUpdater/blob/main/LSL/OpenCollar%20-%20badwords.lsl#L395
The addon now gets the settings like this (to see add):
//DEBUG llOwnerSay("link_message string: " + (string)sStr);

and you will see the following (snippet)
with 3 badwords:

link_message string: badwords_badwordson=true
[08:54:30] OpenCollar-3.932-full: link_message string: badwords_badwords=test-badword
[08:54:30] OpenCollar-3.932-full: link_message string: badwords_testword2=testword3
[08:54:30] OpenCollar-3.932-full: link_message string: badwords_penance=tis 's the testpenance!

gives one badword (first one) and a working penance

even worse with 2 badwords:

link_message string: badwords_badwordson=true
[09:08:17] OpenCollar-3.932-full: link_message string: badwords_badwords=test-badword
[09:08:17] OpenCollar-3.932-full: link_message string: badwords_testword2=penance
[09:08:17] OpenCollar-3.932-full: link_message string: badwords_penance=tis 's the testpenance!
[09:08:17] OpenCollar-3.932-full: link_message string: badwords_tis 's the testpenance!=

the problem is with the given dump, one then puts into the defaultsettings NC -
and with the parsing within the badwords addon as it is done here,
https://github.com/OpenCollar/OpenCollarUpdater/blob/main/LSL/OpenCollar%20-%20badwords.lsl#L411

because even the following, modified line does not really work
User_badwords=badwordson~true~badwords~test-badword~badwords~testword2~penance~tis 's the testpenance!
giving only this:

link_message string: badwords_badwordson=true
[09:18:53] OpenCollar-3.932-full: link_message string: >badwords_badwords=testword2
[09:18:53] OpenCollar-3.932-full: link_message string: badwords_penance=tis 's the testpenance!

getting the last badword and working penance

Suggestion

• lets dump settings this way
  User_badwords=badwordson~true~badwords~test-badword,testword2,testword3~penance~tis 's the testpenance!

link_message string: badwords_badwordson=true
[09:23:33] OpenCollar-3.932-full: link_message string: badwords_badwords=test-badword,testword2,testword3
[09:23:33] OpenCollar-3.932-full: link_message string: badwords_penance=tis 's the testpenance!

• and then modify
  https://github.com/OpenCollar/OpenCollarUpdater/blob/main/LSL/OpenCollar%20-%20badwords.lsl#L413
  to this
  g_lBadWords = llParseString2List(llToLower(sValue), [","], []);

using above line in defaultsettings NC and this code modification is working even while settings dump still shows it in a different way, after adding a new badword

User_badwords=badwordsontruebadwordstest-badwordtestword2testword3testword4penancetis 's the testpenance!

I'm also not sure, if this line may need some rework cosmetic issue
https://github.com/OpenCollar/OpenCollarUpdater/blob/main/LSL/OpenCollar%20-%20badwords.lsl#L192
as the output after adding a badword is:

Zopf Resident is forbidden from saying test-badword, testword2, testword3, testword4, or test5
The penance phrase to clear the punishment anim is 'tis 's the testpenance!'.

while showing them gives

[10:16:46] OpenCollar-3.932-full: Badwords are: test-badword or testword2 or testword3 or testword4 or test5

Had no issues with my collar up until this last update. The collar comes off when locked and Master cannot access the menu..when we try an earlier collar it works just fine...please help as it is my special collar He bought for me

Recently with the past 2 updates, almost every time i teleport, i get stuck either in position or unable to put myself into position. The ONLY way to fix this is to re-log. I can't "reset' scripts as has been suggested because that knocks my owner off my collar and unless he's online, i can't re-add him as the collar states that no one by that name is nearby to be added. I don't know what else to do, but re-logging every time is getting really really old.

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
As a primary owner of your own collar, go to a quiet place. Enter the Leash menu and select LeashTo.

What is the expected output?
Something like "Unable to find any nearby avatar targets."

What do you see instead?
"Unable to find any nearby targets."

What version of the collar (or other item) are you using?
3.931

Please provide any additional information below.
I don't use the leash option that much. As a user/tester I expected this option LeashTo to be valid for non avatars, like a leash post, too. By adding just the word "avatar" in the message this may take some confusement away.

The Firestorm AO implemented the OC protocol to control the Firestorm AO. This functionality was removed in 3.9.

http://wiki.phoenixviewer.com/fs_controlling_ao_w_scripts
https://code.google.com/p/opencollar/wiki/OpenCollarAttachmentProtocol

when press button "ClearAll", DialogBadwords(kID, iNum) call twice, in line 363 (in UserCommand() function) and in line 475 ( in DIALOG_RESPONSE processing )

I think, in line 363 DialogBadwords(kID, iNum) is not needed

i have turian collar, OC scripted. When i try to use the floating text, it elongates the leash ring on my collar to where it stands out farther than my shoulders. The text appears in white above my head but the leash ring gets huge and stretched thin, so i cant use the floating text feature i guess

From Appearance, Position:
Backward moves right
Forward moves left
Up moves forward
Down move back
left moves up
right moves down

when appearance is set to hide, padlocks appear and disappear when the lock / unlock

Proposed solutions:

integer g_hide ; // global hide

SetLockElementAlpha() //EB
{
if (g_hide) return ; // ***** if collar is hide, don't do anything
...
...
...
}

changed(integer iChange)
{
if (iChange & CHANGED_OWNER)
{
llResetScript();
}
if (iChange & CHANGED_COLOR) // *********************
{
g_hide = !(integer)llGetAlpha(ALL_SIDES) ; //check alpha
SetLockElementAlpha(); // update hide elements
}
}

Menu Animations:
"AO ON" "AO OFF" "Give AO" buttons don't work

Pose animations stops after a few seconds

The @emote removal removed an EXCEPTION to the emote truncation.

When @sendchat is enabled emotes are truncated to 15 characters. The @emote=add would enable an exception to this truncation and allow for full length emotes (barring special characters) even when chat was not allowed.

When the subspy feature for listening is turned on there is a problem that keeps happening over a course of a few hours and it ends with a " [script:OpenCollar - subspy] Script run-time error Stack-Heap Collision" that occurs and the owner no longer recieves the sub's chat. This never happened on the previous version of the collar.. it just seems to be happening now that I have updated to 3.935 which leads to an unhappy, Master. Please help!

When he's not happy ain't nobody happy!

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
In the Leash menu, select Post.

What is the expected output?
A dialog to select a leashing post.

What do you see instead?
The Leash menu (remenu) and shortly after, the expected dialog to select a leashing post. The Leash menu does not respond to any of the buttons.

What version of the collar (or other item) are you using?
3.931

Please provide any additional information below.

two more things could be useful for the Main Menu:

1. we want to see the version we are running in the menu text
2. the ℹbutton could be a pop-up menu instead a load webpage menu; we can add links and other "About" information there

some useful snippets I got from the update script regarding version:

my_version_request = llGetNotecardLine("~version", 0); 

    else if (llList2String(cmd_parts, 0) == "version")
    {
        Notify(id, "I am running OpenCollar version " + my_version, FALSE);


 dataserver(key id, string data)
    {
        if (id == my_version_request)
        {
            // we only ever read one notecard ("~version"), and it only ever has
            // one line.  So whatever we got back, that's our version.
            my_version = data;        

            // now request the version from github.
            CheckForUpdate();            
        }
    }

those snippets any useful? shall we do that?

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
As a sub, click Owners -> Reset All (whether you have owners or not)

What is the expected output?
A dialog that can be used, or no dialog at all.

What do you see instead?
A dialog that can not be used and a runaway message (the latter is fine).

What version of the collar (or other item) are you using?
3.931

Please provide any additional information below.
The messages read:
[14:19:40] OpenCollar - 3.931: Running away from all owners started, your owners will now be notified!
[14:19:40] OpenCollar - 3.931: Runaway finished, the collar will now release locks!
[14:19:40] OpenCollar - 3.931: You unleash yourself from .
[14:19:40] OpenCollar - 3.931: Unlocked.

This is a copy of issue #1515 at code.google.com, which reports this would have been fixed in version 3.800. Changing (internally) from reset to runaway may have changed insights that may have caused this issue to reappear.

The runaway-command seems to be processed in the auth script, from line 840 and further. At the end of the block, the script resets, so there's no way this script can react on any dialog response. (However, at this point it's not clear to me what script causes the new dialog.)

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
Update the collar to 3.931. Hit Get Version in the Help menu.

What is the expected output?
A chat line reading "OpenCollar: I am running OpenCollar version 3.931"

What do you see instead?
A chat line reading "OpenCollar: I am running OpenCollar version 3.930"

What version of the collar (or other item) are you using?
3.931 (updated from 3.930)

Please provide any additional information below.
The contents of ~version reads 3.931.
The Main dialog reports the version correctly: 3.931.

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
Use Updater 3.931. Select Custom. There's a button "OldAndBu". Hit it.

What is the expected output?
No message, or actually, not this button.

What do you see instead?
The Updater reports:
"OpenCollarUpdater Dev/Beta/RC - 3.931: The OldAndBusted bundle is deprecated and must be removed."

What version of the collar (or other item) are you using?
OpenCollar Updater 3.931

Please provide any additional information below.
(Not sure whether this is a bug, defect, hidden feature or something that was forgotten. But as a user, I got confused.)

It has been reported that the default settings notecard command for setting the label is case sensitive where all other commands in the notecard are not.

Minor bug, as they should be using the dump command to save the format.
Looks like maybe a convert to lower case command is missing in the label script before it processes the command

There is a problem with loading your scripts, once you update completely, the actual version manipulates and enlarges the prim that you place them in, sadly this alters the look of the collars i create and is rather annoying. Please fix this issue immediately.

This is an issue testing Eve Keneinan's issue that the bug tracker "start new issue" link is broken

I tried updating a collar by wearing one, the tried again on another collar dropping it first. Neither one has a "touch" menu. The only way to get the menu is chat command. Also, can right click, and there is no "touch" option in the pie menu. I also tried resetting the scripts on the first collar.

1 start off with Basic collar
2 update using updater
3 reset collar
4 pick an animation i choose (kneel)

[23:33:35] OpenCollar: Error: Somehow I lost permission to animate you. Try taking me off and re-attaching me.

Dont matter what animation you pick from that point thats all you get, Sure reset collar again get same results.

When browsing RLV folders, ?? is displayed instead of state check boxes.

After updating from 3.910, state check boxes are displayed as question marks.
Item numbers are still displayed.

e.g.
"0 ??Ball Gag"
"1 ??Lockable Panel Gag"

3.916 also did the same.

Store_StartScaleLoop()
{
g_lPrimStartSizes = [];
integer iPrimIndex;
vector vPrimScale;
vector vPrimPosit;
list lPrimParams;
if (llGetNumberOfPrims()<2)
{
vPrimScale = llGetScale();
g_lPrimStartSizes += vPrimScale.x; <<<<< this is correct???
}
else
{
for (iPrimIndex = 1; iPrimIndex <= llGetNumberOfPrims(); iPrimIndex++ )
{
lPrimParams = llGetLinkPrimitiveParams( iPrimIndex, [PRIM_SIZE, PRIM_POSITION]);
vPrimScale=llList2Vector(lPrimParams,0);
vPrimPosit=(llList2Vector(lPrimParams,1)-llGetRootPosition())/llGetRootRotation();
g_lPrimStartSizes += [vPrimScale,vPrimPosit];
}
}
g_iScaleFactor = 100;
}

I think we eventually should add a little feature to the Setting menu that would parse a defaultsettings card on clicky. Imagine it like this:

1. wearer/owner creates a custom defaultsettings card
2. plays with stuff, changes cosmetic things and what not
3. wants it all back how it was stored in the card
4. goes to help/debug -> setting and clicks a "Reset" or some such button

Also should we have a llTextBox for users to be able doing defaultsettings copypasta? This would make it possible for people to backup their settings anywhere, a notecard in the inventory, a text or doc file on their computer.. and then just paste them in the textbox to load them up.

Reported by Tuco Solo at http://code.google.com/p/opencollar/issues/detail?id=1572

What steps will reproduce the problem?

1. Lock the appearance menu
2. Read the dialog text of the next menu that pops up

What is the expected output?
A sentence like "The appearance of the collar has been locked. To modify it an owner has to unlock it."

What do you see instead?
"The appearance of the collar has be locked. To modified it a owner has to unlock it."

What version of the collar (or other item) are you using?
3.923

Please provide any additional information below.
It's on line 369, in DoMenu().

1 start with basic collar
2 update it
3 reset it just for the hell of it
4 goto rlv > misc - and forbid all

now goto options > dump cache

5 Take this line and paste it into Default settings inside collar User_rlvmisc=shownamesnflynfartouchneditnreznshowinvnviewnotenviewscriptnviewtexturenshowhovertexthudnshowhovertextworldnshowhovertext~n

wont restrict the wearer.

Try same with with say Map/TP or Talk works just fine.

When Real Leash addon is enabled and sub is leashed, restrictions apply.
Those restricions still apply when leash holder logs off. Bad thing when owner/leash holder forgets to unleash before leaving. Need to check if wearer is leashed to post/object or person

The general idea behind the #rlv folder is to allow owners to use the subs restraints.
The last three updaters 3.915 3.916 and 3.917 (all official releases in the month of September) do not show the status of the individual restarint items, thus making it impossible for the owner to identify the restraints status.
I have already advised my groups not to use new updaters any more for the time being and stay with vs 3.910

When a self-owned sub orders themself to Stay (Leash menu), 2 similar messages will be sent to the same person (the sub).

[09:28:32] OpenCollar: Tuco Solo commanded you to stay in place, you cannot move until the command is revoked again.
[09:28:32] OpenCollar: You commanded Tuco Solo to stay in place. Either leash the slave with the grab command or use "unstay" to enable movement again.

I would suggest merging those 2 messages into one.
In the leash script, StayPut() (line 465 and further):

llOwnerSay(llKey2Name(kIn) + " commanded you to stay in place, you cannot move until the command is revoked again.");
Notify(kIn, "You commanded " + g_sWearer + " to stay in place. Either leash the slave with the grab command or use \"unstay\" to enable movement again.", FALSE);

change to:

if (kIn == g_kWearer) {
    llOwnerSay("You commanded yourself to stay in place, you cannot move until the command is revoked again.");
}
else {
    llOwnerSay(llKey2Name(kIn) + " commanded you to stay in place, you cannot move until the command is revoked again.");
    Notify(kIn, "You commanded " + g_sWearer + " to stay in place. Either leash the slave with the grab command or use \"unstay\" to enable movement again.", FALSE);
}

(I know, it may be a bit silly to command yourself to Stay in the first place. But then again, the option is there. It could make sense to hide this option for the self-owned sub but it's easier to just make the output more thought of. Any thoughts anyone?)

Exceptions menu is bugged. Can not use any of the features in the menu checked or unchecked. Can not Force-TP, can not restrict IMs from owners, etc.

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
Wear the Leash Holder and click it. Select one of the buttons in the main menu.

What is the expected output?
A submenu with a fancy "⏏" as up-button.

What do you see instead?
The old "^" up-button.

What version of the collar (or other item) are you using?
The Leash Holder in collar 3.931

Please provide any additional information below.

• Version numbers of OC scripts in the leash holder:
  dialog 3.400
  handle 3.422
  update (no version in script name)
• Regarding the update script: it tries to contact a web address at data.mycollar.org. Is this still actual? It also relies on the description of the object, for retrieving name and version. I also believe this is outdated? Normal operation seems unaffected, btw.

Currently neither wearers nor owners get any RLV notification if logging on with RLV disabled in the viewer. Things would happen here -> https://github.com/OpenCollar/OpenCollarUpdater/blob/beta/LSL/OpenCollar%20-%20rlvmain.lsl#L558

However, is it necessary to have this notification at all? Usage case would be that a wearer logs on with RLV disabled and cold boots the collar to rid of the owner and restrictions. It's a moral question if that's an "OK" thing to do. Sort of cheating or dodging the notification that would already be there when using runaway or the safeword. I vote for getting rid of this notification all together, it causes more drama in everyday use than it would actually be used by extra-geeky subs to cheat in hope to get scolded. A person can only be controlled so far in my opinion and we shouldn't add fuel to drama prone stuff. What happens with the notification is hinting the sub attempted maybe a break of trust and consent; that will in most cases always come across wrong.

That's a Yay for ridding of it all together and a Nay for fixing and keeping it. Just comment with either, please.

Yay.

The Return Key option when Timer finishes one of it's timers doesn't work. In fact if touching the ( )Return Key button in the Timer menu won't do anything but close the menu.

What is your Second Life name?
Tuco Solo

What steps will reproduce the problem?
Rez an updater nearby, hit the Update button

What is the expected output?
A Yes/No-dialog asking me whether I wish to really update.

What do you see instead?
A Yes/No-dialog asking me whether I wish to really update, and a second dialog with the previous dialog (a so called remnu).

What version of the collar (or other item) are you using?
3.929 (and verified with the updated 3.931)

Please provide any additional information below.

I ran some tests and while I have good results on Auto mode, I have none on Ask mode, I can click Yes until the object gives up trying to tap into the collar relay..

that's an urgent one, we gotta look at that asap

Collar Update not working... Dunno why either... Any suggestions

If someone tries to add themselves on the collar in a region with no other agents present, the person finder handler will not show up the wearer themself as possible owner.

Found while converting Collar scripts into cuff scripts.
Using 3.931 code
I would expect access to rlv menu to turn RLV on or off (in the cuffs we only use RLVMAIN)
instead I get -
Still querying for viewer version. Please try again in a minute.

comments -
the code says it sould work as so -
//on script start, query db for rlvon setting
//on rlvon response, if rlvon=0 then just switch to checked state. if rlvon=1 or rlvon=unset then open listener, do @versionnum, start 30 second timer
//on listen, we got version, so stop timer, close listen, turn on rlv flag, and switch to checked state

It is hanging waiting for a responce from the DB_RESPONCE on the link channel 2001.
In the collar I can see a rlvon responce on 2001, which I think is coming from the settings script... but in the cuffs the settings script (unmodified collar settings script) does not send this command even with adding it to defalt notecard.
I guess the settings script is waiting for a responce from another script first (one I have not converted to 3.931)
I have got around this problem for now
by adding -

if (g_iRLVOn)
{
CheckVersion(FALSE);//NG hack to force it to check RLV
}

into the default, static_entry section

not sure if this is a bug or it is susposed to work this way

if someone sets a timer in the collar, say the online timer, and later someone comes along and hits the both timer button without setting a RL timer it messes up the timer. You get double menus that neither work and sometimes the sub can access the collar, sometimes they can't. You can't adjust the timers or stop them until you uncheck the both timer button, which if you don't notice it is check you have no idea what's going on. This is probably cause because one timer is at 0 and the other timer is set.

The both timer button should be disabled when only one timer is running or just remove that silly RL timer all together. What use is a timer if all you have to do is log out till it expires :)

On the 3.94 update when using the spyware, my Master is getting that message on big posts to local. This is a BIG problem for para-rp'ers. On the 3.8 version the spyware was perfect .. never had a problem until it just stopped working the other day. Is there anyway to get this fixed?