Giter VIP home page Giter VIP logo

base-templates's Introduction

base-templates's People

Contributors

arnoldzokas avatar chriscartlidge avatar chrisonside avatar dependabot[bot] avatar dependencies-bot avatar dipunm avatar greenkeeper[bot] avatar kmcrawford avatar matteofigus avatar nickbalestra avatar ricardo-devis-agullo avatar seif avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

base-templates's Issues

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Improvements

  • Use async methods only (ie from fs/fs-extra)
  • Compile could be written without async.waterfall as the 3 compilations could perhaps be run in parallel

Lerna updates

  • use lerna publish -m to adhere to commitizen

  • use --conventional-commits when publishing

  • address and update the following related deprecations:

  • npm WARN deprecated [email protected]: Check out CommitLint which provides the same functionality with a more user-focused experience.

  • npm WARN deprecated [email protected]: Please update conventional-changelog to >1.0.0. If you are running the cli, use conventional-changelog-cli

Templates to better support dev env

Template could expose an alternative url (for the externals). ie: a normal url for production and a devUrl for dev (think of ../library.min.js and ../library.js). For example the react non minified/production version of the library support extensive error/debugging

Dependencies.io troubleshooting

We're opening this issue to inform you about problems with your dependencies.io configuration or build failures.

We'll add a comment here when we see problems. You can close this issue when
you have things resolved -- we'll open it back up if we detect new problems.

Helpful links:

Note: To help keep your repo as clean as possible, this is the only issue
that we're going to open and comment on. Feel free to delete the comments
that are made as you resolve them, if you want to keep this issue short and tidy.

infinite-loop-loader: Fails with if/else while shorthand syntax

infinite-loop-loader produces invalid Javascript when transforming if, else and while in shorthand syntax.

For example, try using infinite-loop-loader with this:

if (false) while (i++ < 10) { console.log('This is ok'); }
else while (i++ < 10) { console.log('This else breaks things'); }

The output from Webpack:

ERROR in ./index.js
Module parse failed: /Users/davidfutcher/code/prefunnel/infinite-loop-loader-example/node_modules/infinite-loop-loader/index.js??ref--0!/Users/davidfutcher/code/prefunnel/infinite-loop-loader-example/index.js Unexpected token (10:0)
You may need an appropriate loader to handle this file type.
|       __ITER--;
|        console.log('This is ok'); }
| else
|       var __ITER = 1000000000;
|       while (i++ < 10) { if (__ITER <= 0) {

Looks like the loader assumes it's adding code into a bracketed block, which is not necessarily true (there are obvious missing brackets between the else and the var). This syntax (for better or worse!) exists in the wild - it was found when trying to import d3-time into an OC - see https://github.com/d3/d3-time/blob/master/src/interval.js#L43.

Merge with oc-template-handlebars

Due to the many shared packages that both legacy templates (jade and handlebars) rely on, Is advised to merge them both together and rename this repo into base-templates so that development on each template together with work needed on any shared package (webpack configurator, infinite-loop-loader,...) will be more accessible and publishing will require way less efforts. Nonetheless we already have a lerna structure on both, so the transaction will be seamless

Dependencies.io troubleshooting

We're opening this issue to inform you about problems with your dependencies.io configuration or build failures.

We'll add a comment here when we see problems. You can close this issue when
you have things resolved -- we'll open it back up if we detect new problems.

Helpful links:

Note: To help keep your repo as clean as possible, this is the only issue
that we're going to open and comment on. Feel free to delete the comments
that are made as you resolve them, if you want to keep this issue short and tidy.

Shared packages

Everything within the to-be-published directory being worked on #15 should be moved into own package.

oc-external-dependencies-handler cannot load webpack lib

We think it may be related to the following PR:
https://github.com/opencomponents/base-templates/pull/372/files

However we are now receiving the following message when booting up OC when using the oc-template-es6-compiler with the following error message:

Error: Cannot find module './lib/oc-webpack'
at Function.Module._resolveFilename (module.js:548:15)
at Function.Module._load (module.js:475:25)
at Module.require (module.js:597:17)
at require (internal/module.js:11:18)

I can look at this, but will need some time.

If you're seeing a similar issue, fixing oc-template-es6-compiler to 1.1.3 fixes the issue for now.

Changelog

Add lerna-changelog so that we can get changelog automatically upon publishing

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.