opencubicchunks / cubicchunks3 Goto Github PK

• Consider testing DistanceManager#shouldForceTicks
• Distance#Manager removeOnClosing has non-cc ticket types

ChunkMap

• Only cc_updateChunkScheduling and calls from ChunkHolder#cc_getOrScheduleFuture are tested

ChunkHolder

• Only cc_getOrScheduleFuture is tested

MixinMinecraftServer

• setInitialSpawn, only unit test, requires integration test
  • cc_replaceChunkPosInSetInitialSpawn
  • cc_replaceGetWorldPositionInSetInitialSpawn
• prepareLevels only unit test, requires integration test
  • cc_replaceAddRegionTicketInPrepareLevels
  • cc_waitUntilCubicGenerationComplete

MixinLevel

• Mixins

  • setBlock only unit test, requires integration test
    • cc_replaceLevelChunkInGetChunkAt
    • cc_replaceLevelChunkInSetBlockState
    • cc_replaceLevelChunkInMarkAndNotifyBlock
  • getBlockState only unit test, requires integration test
    • cc_replaceLevelChunkInGetBlockState
    • cc_replaceLevelChunkInGetBlockState (overload)
  • getBlockEntity only unit test, requires integration test
    • cc_replaceGetChunkAtInSetBlockEntity
  • getFluidState only unit test, requires integration test
    • cc_replaceGetChunkAtInGetFluidState
  • setBlockEntity only unit test, requires integration test | might break if vanilla code is added after the cancel.
    • cc_replaceLevelChunkInSetBlockEntity
  • removeBlockEntity only unit test, requires integration test
    • cc_replaceGetChunkAtInRemoveBlockEntity
    • cc_replaceLevelChunkInRemoveBlockEntity
  • isLoaded only unit test, requires integration test
    • cc_replaceHasChunkInIsLoaded
  • loadedAndEntityCanStandOnFace only unit test, requires integration test
    • cc_replaceGetChunkAtInLoadedAndEntityCanStandOnFace
  • blockEntityChanged only unit test, requires integration test
    • cc_replaceBlockEntityChanged
  • getCurrentDifficultyAt only unit test, requires integration test
    • cc_replaceGetCurrentDifficultyAt

• CC methods

  • LevelCube cc_getCube only unit test, requires integration test
  • CubeAccess cc_getCube only unit test, requires integration test
  • cc_getCubeAt only unit test, requires integration test
  • cc_hasCubeAt no test
  • cc_hasCubesAt no test

CubicChunkSource

• None tested, missing ServerChunkCache and ClientChunkCache to test.

This can be almost entirely copied from CC2

For P1 this packet should contain only the chunk position, as there are no heightmaps, biomes, etc. that exist in P1.

Assuming no other data is necessary, this packet should just inform the client to create the LevelChunk.