opencv / ci-gha-workflow Goto Github PK

The bug is introduced in #78 , where ${{ github.workflow }} is used to set group name with the workflow name. However, ${{ github.workflow }} returns the parent workflow name, making all jobs triggered by a commit in a PR will lineup together.

For example, in https://github.com/opencv/opencv/actions/runs/3477363324, the Annotations section shows the group name of concurrency is PR:4.x-refs/pull/22814/merge (PR:4.x is the name of https://github.com/opencv/opencv/blob/4.x/.github/workflows/PR-4.x.yaml), but the expected return values of ${{ github.workflow }} should be OCV PR:4.x ARM64, OCV PR:4.x U20 and more (workflow files in this repo). So one job in this lineup will keep running but others will be cancelled.

opencv/opencv#23349

Is it safe to use injections here via env var? I suppose once SOURCE_BRANCH_NAME and other env vars are created, they should be referenced simply as $SOURCE_BRANCH_NAME, otherwise it may not have proper effect.

Please, see Remediation section as a reference.

If you compare the build artifacts from these 2 runs

1. https://github.com/opencv/ci-gha-workflow/actions/runs/6345578976
2. https://github.com/opencv/ci-gha-workflow/actions/runs/6425845547

The first is much bigger than the second. One big difference between the 2 is OpenCV-android-sdk/sdk/native/libs/x86_64/libopencv_java4.so

The size of libopencv_java4.so is the same for all other architectures (armeabi-v7a, arm64-v8a, x86). For whatever reason it only doubled in size for x86_64.

OpenCV-android-sdk/sdk/native/libs/x86_64/libopencv_java4.so should be around 26 MB, but it ends up being over 52 MB

I propose to continue running tests when build completes but previous unit tests fail. You can see from this log that GitHub Actions workflow stops once there is an error. However, for a workflow which completes building, stopping at one possible failed unit test is too inefficient.

An implementation to this feature can be as follows:

jobs:
  BuildAndTest:
    steps:
        # ...
        - name: Build OpenCV
           id: build-opencv # used as reference below
           run: #...
        # ...
        - name: Accuracy:core
          if: ${{ always() && steps.build-opencv.outcome == 'success' }}
          run: #...

This should work and show "failed" in overall page if one test fails.

What do you think? @alalek @asenyaev @asmorkalov

Reference:

• https://stackoverflow.com/a/71434730/6769366
• https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions

System Information

See https://github.com/opencv/opencv/releases

Detailed description

N/A

Steps to reproduce

N/A

Issue submission checklist

• I report the issue, it's not a question
• I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
• I updated to the latest OpenCV version and the issue is still there
• There is reproducer code and related data files (videos, images, onnx, etc)

Build passes with many active build warnings.

https://github.com/opencv/opencv/actions/runs/5583870111/jobs/10204634906?pr=23897