Compilation issue with debian unstable (trixie) about odr-audioenc HOT 5 CLOSED

https://gitlab.onelab.info/gmsh/gmsh/-/issues/2416

Some C++ Standard Library headers have been changed to no longer include other headers that were being used internally by the library.

from odr-audioenc.

Hi @mpbraendli,

I think I have found the explanation:

1. include dependency path
   contrib/ReedSolomon.cpp - stdexcept - string - bits/char_traits.h - cstdint

2. Header file <bits/char_traits.h>
   bullseye:

   #if __cplusplus >= 201103L
     #include <cstdint>
   

   unstable:

   #if __cplusplus >= 201103L
     # include <type_traits>
     #if !defined __UINT_LEAST16_TYPE__ || !defined __UINT_LEAST32_TYPE__
       # include <cstdint>
     #endif
   #endif
   

Somehow, UINT_LEAST16_TYPE and/or UINT_LEAST32_TYPE are defined in unstable, preventing cstdint from being included by the preprocessor.

Anyhow, I believe that <cstdint> should be added to source file contrib/ReedSolomon.cpp since the latter explicitely refers to type uint8_t

In order to push the package to debian, I would need this change to be included in a new release...

from odr-audioenc.

Hi, yes the header #include is missing. Same issue popped up in ODR-DabMux too.

I need to do releases for all tools that have ReedSolomon.cpp

Thanks for the reminder

from odr-audioenc.

Merci @mpbraendli

By the way, I confirm that once you add #include <cstdint> to ReedSolomon.cpp, the compilation is still OK in bullseye (and probably bookworm, although I didn't check, yet)

from odr-audioenc.

Fixed in v3.4.0

from odr-audioenc.