openedx / frontend-app-communications Goto Github PK

Abstract
Node 16's support will end on September 11, 2023. So we have to upgrade node JS to v18 before that.

Extras
Project should use .nvmrc to have a consistent node version
We have to update Readme accordingly.

Upgrade Node JS from 16 to 18

Description

(This is being tracked via openedx/wg-translations#16.)

There have been independent reports of problems with localization related to this MFE, which has been made part of the official Tutor release as of Palm. The main objective here is to find out what the problems are, and then to coordinate fixes.

Report 1

This was first noted on Slack by @sambapete on 2023-08-04. Thread summary:

• There seems to be no Transifex resource for the MFE
• There are no translations in https://github.com/openedx/frontend-app-communications/tree/open-release/palm.1/src/i18n/messages
• On 2023-03-24 a PR was merged that upgraded the repo's Transifex support to v3. It is equivalent to others such as this other one in frontend-app-learning, the latter of which seems to be working properly.
• It seems these translations are still handled by Jenkins jobs, over which the community has no visibility

Report 2

An issue was opened in this repository noting that there doesn't seem to be a Transifex resource for frontend-app-communications.

Solution space

In a separate thread started to coordinate fixing this and other outstanding i18n issues, it was hypothesized that the Jenkins bot responsible for exporting strings to Transifex was not properly set up. Evidence: no commits by edx-transifex-bot to src/i18n.

Assuming this is the only problem, a solution was proposed where instead of trying to hunt down the maintainers of the bot - a recurring issue - frontend-app-communications should be one of the first repositories to work exclusively with https://github.com/openedx/openedx-atlas (as introduced via OEP-58).

The potential downside is that for Quince, and until all repositories are ported to openedx-atlas, translators would have to work with two Transifex projects. However:

• At least one active Transifex user (@sambapete) noted that that would be acceptable.
• @OmarIthawi notes that it might be possible to synchronize Transifex projects so translators need not know about the separate projects

Standing questions

• The cut for Quince.master is just a month away. Will this be ready in time?
• How will the proposed solution be handled in Tutor, as per https://github.com/overhangio/tutor-mfe#adding-custom-translations-to-your-mfes?

Additional references

• https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html
• openedx/edx-platform#32994
• openedx/openedx-translations#569

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• fix(deps): update dependency jquery to v3.6.2
• fix(deps): update dependency @edx/frontend-component-header to v3.6.0
• chore(deps): update dependency @edx/frontend-build to v12
• chore(deps): update dependency @testing-library/react to v13
• chore(deps): update dependency es-check to v7
• chore(deps): update dependency glob to v8
• chore(deps): update dependency husky to v8
• chore(deps): update dependency jest to v29
• chore(deps): update node.js to v18
• fix(deps): update dependency @edx/frontend-platform to v3
• fix(deps): update dependency @edx/paragon to v20
• fix(deps): update dependency @tinymce/tinymce-react to v4
• fix(deps): update dependency axios to v1
• fix(deps): update dependency react-redux to v8
• fix(deps): update dependency tinymce to v6
• fix(deps): update font awesome to v6 (major) (@fortawesome/fontawesome-svg-core, @fortawesome/free-brands-svg-icons, @fortawesome/free-regular-svg-icons, @fortawesome/free-solid-svg-icons)
• fix(deps): update react monorepo to v18 (major) (react, react-dom)
• fix(deps): update react-router monorepo to v6 (major) (react-router, react-router-dom)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency ejs to 3.1.7 [security]
• fix(deps): update dependency @edx/frontend-component-footer to v11.6.0
• chore(deps): update actions/checkout action to v3
• chore(deps): update actions/setup-node action to v3
• chore(deps): update codecov/codecov-action action to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

In the navigation compoenet which suppose to link back to instructor tab in the lms

The probelm is; window.location.pathname.split('/')[2] woud return course-id if public path is / the case The typical case of edx, while it would return courses if public path, is something, the case of tutor.

Extra context

window.location.pathname in tutor would equal to /PUBLIC_PATH/courses/cours-id/bulk_email course id is the third index.

While if public is set to / it would equal courses/cours-id/bulk_email course id is the second index.

Suggest solution:

• Use state to get course-id instead of link.
• Figure out if public path is used, if it's used then get it course by getting the third index instead of the second.

This bug was found while checking this #125.

the current state of peer dependencies prevents paragon upgrades due to the @edx vs @openedx scope difference

once the following PRs are merged we should update these dependencies to allow paragon upgrades using the @openedx scope

• openedx/frontend-component-footer#394
• openedx/frontend-component-header#456
• openedx/frontend-platform#636

Description

See the parent ticket for the general description and motivation, openedx/public-engineering#267. Make sure to follow its recommendations for each step of the process.

Hi
I couldn't find the frontend-app-communications resource in the transifex. maybe you forgot to add it there?

This repo is currently using React JS v16. We need to upgrade it to React 17 before moving to latest React version(v18).
React 17 doesn’t add any new developer-facing features, so its upgrade might not cause any breaking changes. Our end goal is to upgrade React to v18 but v18 no longer support enzyme, so we are upgrading to React 17 and then we’ll migrate from enzyme.

Epic Link

React 17 upgrade