[BUU] Errors when creating variants about openfoodnetwork HOT 6 CLOSED

Hi @filipefurtad0 , the error in the screenshot for the Price field.
I tried replicating on master, and interestingly got a slightly different problem:

1. Enable feature toggle admin_style_v3
2. On the /products page, choose 'New variant'; set it to have an On demand value. (do not change any other values)
3. Hit Save changes.
4. Notice changes are not saved, the Unit field has an error ("can't be blank"), and the On hand field has reverted to 0 (not 'on demand').
   

Can you provide any more details how you had the error on the price field?

I was aware of this problem with the unit field: the unit field is blank by default (1), but when you open the popout (2), it contains a 1. It's not until you change that value that the change is registered and saved.

from openfoodnetwork.

So in summary (from what I can see so far), it appears to be three problems with creating new variants:

1. Unit field is out of sync with the popout
2. Price field validation error? (I thought it always defaulted to 0.00)
3. 'On demand' selection is lost when error on saving new variant

from openfoodnetwork.

I've removed the good-first-issue label while we investigate, but FYI that price field error was the one I had in #11633
=> the error appeared on a product I was NOT editing. So perhaps @filipefurtad0 edited a on-hand value, saved and got the price error on another product, hence this issue.
Now how to reproduce this... 💩

from openfoodnetwork.

I can't reproduce this either now @RachL, sorry. I'm not sure what changed, or whether I just bumped on what you describe @dacook, i.e., in the case that something is left blank, the choice regarding stock is not kept:

Notice changes are not saved, the Unit field has an error ("can't be blank"), and the On hand field has reverted to 0 (not 'on demand').

Therefore, I agree with your summary:

1. Unit field is out of sync with the popout -> indeed. For a 1 kg product, the default value appearing on the dropdown is 0.001, with an empty Display as field:

2. Price field validation error? (I thought it always defaulted to 0.00) -> I think price is mandatory, and can never be left blank. I think it is ok to get an error, when left blank.

3. 'On demand' selection is lost when error on saving new variant -> fully agree, this is reproducible

from openfoodnetwork.

To avoid confusion, maybe it is best to close this issue, and open two issues for points 1) and 3) above? And also for point 2) as well of course, if you feel this is inconsistent behavior (to have Price as a mandatory field).

Looking at #11633 it does seem similar... Although I was not editing a variant, but rather creating a new one. Maybe there is a combination here I'm missing...

from openfoodnetwork.

Ok, created the two issues (mentioned above). I think we can close here.

from openfoodnetwork.