openhpi / video-player Goto Github PK

It seems like the config "videoPreload": false is ignored. Please look at the OpenWHO landing page for an example. Tested on latest Chrome, macOS.

Player loading takes some time in older browsers (firefox < 52, IE, depends on machine speed, up to 8 seconds). It would be nice to see a "video player loading..." text or perhaps loading poster image first with "Loading..." inside.

Safari on iOS may have another name than window.screen.orientation.type --> check
This is needed as every analytics event reads the screen orientation and the player may be unusable if this part causes JS errors on mobile Safari.
Also, _handleScreenOrientationChange()in AnalyticsManager may need to be refactored then.

MacOS Safari doest not support screen orientation, so it cannot be read or changes tracked

When opening a page with the player in Microsoft Edge, the browser show the poster image for just moment - then it disappears and is replaced by black (see screenshot).

Additionally, Edge displays (at least some of) the control icons in black instead of white - also visible on the screenshot above.

When i watch a video with interactive transcript enabled, the browser scrolls up the current line of the transcript to the top of the page, whenever a new cuepoint is reached. Thus, the actual video is out of the current viewport.

The analytics events include the following slide data at the moment:

currentSlide: {
  startPosition: 17,
  thumbnail: "/files/c4dc3d0f-8454-4b45-a602-1c6b04653c44/thumbnails/2100?format=jpg"
}

But the most important information is missing: slide_number

The HPI Open Source license currently refers to Hyrise, i guess.

https://github.com/openHPI/videoplayer/blob/fc44d811b30ced2b48a8db758b518503eb928466/LICENSE#L11-L12

This is caused because FF/IE do not fully support shadow doms. Thus the styling rules are not encapsulated.

One example is the time box:

Sometimes we have HD Stream available only for one of the two videos. The player should be able to handle this:

[{\"hd\":null,\"sd\":\"https://player.vimeo.com/external/241185268.sd.mp4?s=49c371dd04cac9471ab45be9c564bbc37eb06af8\\u0026profile_id=165\\u0026oauth2_token_id=60919992\",\"poster\":\"https://i.vimeocdn.com/video/664695340_1920x1080.jpg?r=pad\"},{\"hd\":\"https://player.vimeo.com/external/241185139.hd.mp4?s=b1104529713f67b201052969c803ce54a9d3d110\\u0026profile_id=174\\u0026oauth2_token_id=60919992\",\"sd\":\"https://player.vimeo.com/external/241185139.sd.mp4?s=ac2fbafe6bc7f8d1f783a124f7e06d6ce894fffe\\u0026profile_id=165\\u0026oauth2_token_id=60919992\",\"poster\":\"https://i.vimeocdn.com/video/664695143_1920x1080.jpg?r=pad\",\"muted\":true}]

There should be the possibility to see a list of most watched videos.

When entering the video with the mouse the controlbar should be visible (maybe semi transparent). It should be overlaying the video at the bottom. When leaving the controlbar should vanish.

See http://schema.org/VideoObject

Data for video player initialization should be able to hold metadata for arbitrary properties defined in the VideoObject schema.

Metadata should be rendered as JSON-LD (JSON Linked Data).

The screen orientation property is not available for IE 11 on Windows 7 and older versions of Edge, which breaks the player. Implement feature detection or handle the property for those browser in a suitable way.

For now, a hotfix has been applied to bypass the issue.

We had to disable this feature to make the player run on IE11/Edge. This should be fixed.

Bower is dying[1][2][3] (the latest blog entry is more than half a year old and does not discuss new bower features, whereas the latest feature-related blog entry is more than a year old). When using bower, I get the following message about it being deprecated:

npm WARN deprecated [email protected]: ..psst! While Bower is maintained, we recommend yarn and webpack for new front-end projects! Please read our blog for more.

We should explore alternatives for using bower like the ones mentioned in the message above.

Go to https://open.hpi.de/courses/javaeinstieg2017/items/oeguHX1rMZFENIixaajPI and select the single stream version, then open fullscreen. Seems like the video cropping doesn't checks the video height. Can be reproduced best with a 4:3 video on a 16:9 screen.

When i play a video with caption, and the last caption ends at e.g. 00:00:30 while the video is longer, the caption won't disappear after 30 secs but last until the video ends.

I assume that this also happens, if you have a break between two captions, e.g.

1
00:00:00 --> 00:00:10
Foo

2
00:00:20 --> 00:00:30
Bar

"Foo" will remain visible until "Bar" starts at 20 secs.

Several links to https://testing.openhpi.de which are not accessible for most people

Please also send an analytics events when the volume is changed or muted.

The text which is shown at the end of the video is currently "Next video". This text should be changeable via configuration.

Video scales, buts stays within the layout of the embedding page. needs to be positioned absolut.

When switching back and forth between the dual and single stream mode while playing the loading never finishes.

Sometimes the initial loading doesn't finish at all and the duration time still shows 00:00.

Both examples are taken from https://openwho.org/courses/pandemic-epidemic-diseases/items/30dQT84OkpHRM1b1SMtZtc.

Currently you need to reload the whole webpage when the connection to the stream was lost. Should retry it automatically

In the current and previous version of Opera (Windows and OS X), the player doesn't work at all (not rendered).

Console shows a JavaScript errror:

Uncaught TypeError: Failed to construct 'HTMLElement': 
Please use the 'new' operator, this DOM object constructor cannot be called as a function.

Couch mode is a feature of tele-task.de. It should be included within this project, too.

HLS Streams always gets preloaded, maybe implement a state that only shows the poster and [implements the player / loads the video] only if play/player clicked, even with HLS.

Currently, the clickable slider area for dual stream consists of the two seperate arrow shapes and the video divider line. This is not very user friendly. I would excpect the bounding box of both slider arrows (combined!) to act as clickable slider area (see drawing).

At the moment the resize control is implemented via Drag'n'Drop. This causes some unwanted side effects like a ghost image and many special rules for certain browsers.
Because of that it should be rewritten with native events like mousemove, mouseenter and mouseleave.

The player should have a functionality to work offline.

When i watch a video with dual stream, and have a single stream fallback available, the button shows the icon for dual stream while being in dual stream mode (and the single stream icon when in single stream mode).

I would expect the button to show, what it will do if i click it... @jprberlin your opinion?

In order to comply with the polymer specification and thus allow publishing a live demo to GitHub pages, the name of this repository needs to be updated to match the custom elements name.

Therefore, I request to change the repo name to openHPI/video-player. I will take care of the required name changes in the code (such as package.json with the corresponding links, etc.).

Afterwards, we might publish an interactive demo, such as I prepared with my fork:
https://mrserth.github.io/video-player/

Reproducible situation: only on stream is configured.
The player will show the switch. If you click it, it changes the view but won't display any video.

The button should not be visible at all, if there is no fallbackStream.

Learn together is a feature of tele-task.de. It should be included within this project, too.

Please outline, what this project is about (Vision)

• This could be put into the Readme file.
• Create a PR with a blog post of the first sentences of the README at https://github.com/schul-cloud/schul-cloud.github.io

Like in other players the progress should be changeable via Drag'n'Drop. Thus the user can drag the progress to the desired position.

See picture - the time box sits too low and disappears into the slide preview bar.

On click, I would expect that the playback speed is changed to one step faster, and on the quality button that it toggled between SD and HD.

When we set the userPreferences: captionLanguage the subtitles and transcript are not loaded and displayed for the fallback stream.

It also seems like this preference is ignored/broken at all. When we set a language, the subtitles are not automatically activated.

/cc @cwillems

There were already first efforts, which has not been brought to an end. For inspiration have a look at feature/chromecase branch.

Once I enable interactive subtitles, the video player keeps to reserve the space for them.
For all videos, if they have subtitles or not. The behaviour also does not change when the interactive subtitles are turned off again.
Browsers: Definitely Safari, maybe others as well.
Steps to reproduce the behaviour:

1. go to a video in e.g. the imdb2017 openHPI course and show interactive subtitles
2. go to a video in e.g. the linux2018 openHPI course => where otherwise the interactive subtitles would be, there is a big black "hole"
3. go back to the imdb2017 video and hide the interactive subtitles
4. go back to the linux2018 video => the hole is still there

Currently, when dragging one of the slider arrows to change the video ratio in dual stream mode, the browser shows a (+) at the mouse pointer (like when copying files), as if i was about to drag the arrow image out of the browser window (e.g. to drop it on the desktop).

This applies at least to Chrome (latest) on Mac OS X (latest).

When there are many videos (3 or more) and the fullscreen is enabled, they may overlap. This occurs when the screen is not high enough.

It would be nice if we could manipulate the video player state from outside, either by an api or events. There is research use case relying on it. ;)

Actions: play, pause, seek, subtitles, transcript, speed, quality, resizer, stream-layout etc.

Social video annotations is a feature of open.hpi.de. It should be included within this project, too.

At the moment this choice is not persisted like everything else.

Auto-generated (e.g. translated) subtitles should be indicated as such in the language dropdowns. Default indicator could be an asterisk (e.g zh*), overwriting the auto-subtitle style via CSS should be possible.