Comments (4)
This actually breaks values that are base64 encoded when they contain a + the plus is decoded to space which is encoded to %20 when the form is submitted. I removed the urldecode and it fixes issues with random signature and assoc_handle errors. I do not see any ill effects to email addresses or other characters that would normally be urlencoded. I think this commit should be removed.
from php-openid.
I don't remember clearly for now, since it was 2 years ago :), but it seems it was an issue with Mail.ru OpenID provider (quite popular email service in Russia).
They required email as user-identifier when openid logging is done, so if we have email, say, [email protected]
, it came already urlencoded to the patched line, so it will look as conf%40mail.ru
. After that POST-form is generated with <input>
-hidden value, so browser will encode this value once again, resulting conf%25%40mail.ru
and that was causing error from their side. My fix did the job for me, so it's up to you to decide if it's needed anymore in common repo.
Thanks for the answer, anyways.
from php-openid.
Maybe you could try to use the function htmlspecialchars rather than encoding the value I think.
from php-openid.
This repo is being archived. Closing issue.
from php-openid.
Related Issues (20)
- You can view the HTML library documentation in the doc/ directory? HOT 1
- Provide info about errors occurring during parsing HOT 2
- PEAR DB is deprecated
- detect.php says that An unexpected URL was returned HOT 1
- CVE-2016-2049 HOT 6
- PHP7 Support HOT 2
- Old php constructors HOT 3
- Auth_OpenID_Parse fails to find link attributes in HTML with uppercase HEAD tag HOT 9
- Why is new changes are not being released in new version? HOT 6
- review plugin page HOT 3
- How to integrate php-openid to piwik? HOT 1
- Auth_OpenID_ServerErrorContainer::$error_code is inaccessible HOT 1
- Default property value public $code = 0; for Auth_OpenID_ServerRespons class breaks code
- Cannot access private property Auth_OpenID_CheckIDRequest::$identity HOT 3
- my bad
- 0986220799 HOT 1
- Thái Bình
- OpenID2 return_to check fails because of nonce being applied automatically HOT 1
- Instrument version reflection from Composer HOT 1
- invalid information in readme.md file HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-openid.