openinf / openinf-util-types Goto Github PK

Checks whether something is null or undefined.

Would be useful for OpenINF/openinf-util-object#133. We can have it out in the next minor…

Can this be achieved solely using Nullish coalescing? Maybe in the TS, but now wondering what ES year we are searching for compatibility with since this is a relatively new language feature.

Refs: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#improved-intersection-reduction-union-compatibility-and-narrowing

/cc @septs @ignoreintuition

We are currently missing a couple of control abstraction object predicates from this library. This was in part due to there not being any documentation associated with them on MDN at the time when we published our initial round of package versions. Since then, along with a few of the good folks over at that project, I've gone ahead and wrote them up and we've gotten the missing pages added to the official JavaScript documentation.

Control abstractions can help to structure code, especially async code (without using deeply nested callbacks, for example).

• Promise: isPromise
• Generator: isGeneratorObject
• GeneratorFunction: isGeneratorFunction
• AsyncFunction: isAsyncFunction
• AsyncGenerator: isAsyncGeneratorObject
• AsyncGeneratorFunction: isAsyncGeneratorFunction

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• build(deps-dev): bump @types/jsdom to v21.1.6
• build(deps-dev): bump typescript to v5.4.4
• chore(deps): bump pnpm to v8.15.6
• build(deps-dev): bump jsdom to v24
• chore(deps): bump actions/checkout action to v4
• chore(deps): bump github/codeql-action action to v3
• chore(deps): bump ubuntu to v22
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

• Add the “hacktoberfest” topic to your repository to opt-in to Hacktoberfest and indicate you’re looking for contributions.

• Apply the “hacktoberfest” label to issues you want contributors to help within your GitHub or GitLab project.

• Add a CONTRIBUTING.md file with contribution guidelines to your repository.

• Choose issues that have a well-defined scope and are self-contained.

• Adopt a code of conduct to create a greater sense of inclusion and community for contributors.

• Be ready to review pull/merge requests, accepting those that are valid by merging them, leaving an overall approving review, or by adding the “hacktoberfest-accepted” label.

• Reject any spammy requests you receive by labeling them as “spam”, and any other invalid contributions by closing them or labeling them as “invalid”.

Refs: https://hacktoberfest.com/participation/#maintainers

We should consider adding the "files" stanza to the package.json to create an explicit allowlist and prevent deploying any unnecessary files to the npm registry as part of our package. This would be preferable to using a .npmignore file, which we have been doing so far but is expected to quickly become unmanageable as more files are added.

[…] only the Cobertura XML format is supported by DeepSource

— https://deepsource.io/docs/analyzer/test-coverage/#javascript

Currently, our tests in this repo are written using tape, yet we are instructed to use Jest to generate the coverage reports… As long as the output is in the expected Cobertura XML format, i think we should be alright, but was unable to find an option for that output using tape nor were there any suitable companion modules altho tap-nyc would seem to be what we are looking for if it would output XML. 😕

We could also use node-tap instead of tape and use its --coverage-report=cobertura flag. I was hoping not to do much refactoring to get this working correctly, but if that is not the case, I have no objection to moving to a more elegant solution if necessary. We seem to have outgrown both tape and tap, but I am also not a huge fan of Jest…

Refs: https://node-tap.org/docs/coverage/#uploading-coverage-to-other-services

Description

Empty functions can reduce readability because readers need to guess whether it's intentional or not. So writing a clear comment for empty functions is a good practice.

Occurrences

There are 10 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/openinf/util-types/issue/JS-0321/occurrences/

I think the @masknet/compartment package exposes the Module constructor that we would be able to use to test our isModuleNamespaceObject function against.

Maybe i am confused tho.

/cc @septs @jackworks

DeepScan has been configured to check for ESLint config instead of using its default rules. This means that it will be ready for us once ESLint is good to go here.

You've analyzed the project with ESLint, but the ESLint analysis failed by the ESLint error.

After checking the details of error and configuring ESLint correctly, please reanalyze this project.

ESLint couldn't find a configuration file. To set up a configuration file for this project, please run:

eslint --init

This package allows for excessive broadness in scope and am having trouble coming up w/ what should be stated in this repo's VISION file. It may likely be the case that the naming can be improved to be focused.

See: typescript-eslint/typescript-eslint#4172

It is preferable not to check the compiled typescript into our repo — let's remove that javascript from here. Additionally, we should use babel for this transpilation instead of the typescript compiler. We will, however, continue using tsc for type checking and type definition generation.