Giter VIP home page Giter VIP logo

Comments (4)

elidrissidev avatar elidrissidev commented on September 26, 2024 2

Could possibly be related to the update made in #2473

from magento-lts.

justinbeaty avatar justinbeaty commented on September 26, 2024 2

It would seem that just the following is enough to fix this:

var targetNode = n.parentNode ?
    n.parentNode.ui.getContainer() : n.ownerTree.innerCt.dom;

Because of the comment on that line:

in later svn builds this changes to n.ownerTree.innerCt.dom

Recall that ext-tree-checkbox.js was not a part of ExtJS, but a plugin for ExtJS written by somebody many years ago. It seems they were aware that the newer version of ExtJS had a breaking change, and documented it in that comment. But since Magento never updated ExtJS, they never updated ext-tree-checkbox.

I am not sure that we need the nested ternary code in @luigifab's original comment, unless we have some case where someone is still running the older ExtJS but with the newer ext-tree-checkbox (which I'm not sure how that would happen.) It also doesn't hurt though, I guess.

from magento-lts.

fballiano avatar fballiano commented on September 26, 2024

true, it's not only you

Screenshot 2023-06-08 alle 22 19 20

from magento-lts.

justinbeaty avatar justinbeaty commented on September 26, 2024

I will take a look at this today. It’s seems I did miss this instance of extjs being used in the backend.

from magento-lts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.