Giter VIP home page Giter VIP logo

Comments (9)

fballiano avatar fballiano commented on June 20, 2024

I get a 404:

Screenshot 2023-08-20 alle 23 46 16

do you need developer mode or something else in order to trigger the error?

from magento-lts.

kiatng avatar kiatng commented on June 20, 2024

I cannot replicate, I get a 404 as well on the OM 20.1.0 PHP8.2.

from magento-lts.

S0FTWEX avatar S0FTWEX commented on June 20, 2024

I get a 404:
Screenshot 2023-08-20 alle 23 46 16

do you need developer mode or something else in order to trigger the error?

My OpenMage was installed manually (extracting openmage-v20.1.0.zip file). Class Zend_Controller_Request_Http is defined only in vendor/shardj/zf1-future/library/Zend/Controller/Request/Http.php but 'vendor' is not mentioned in included paths in get.php (lines 32-35). So my question is: How can manually installed OpenMage load the Zend_Controller_Request_Http class in this file (get.php) if 'vendor' is not include path? I'm missing this vendor autoloader patch (from Mage.php) also here in get.php:

/** AUTOLOADER PATCH **/
$autoloaderPath = getenv('COMPOSER_VENDOR_PATH');
if (!$autoloaderPath) {
    $autoloaderPath = dirname(BP) . DS .  'vendor';
    if (!is_dir($autoloaderPath)) {
        $autoloaderPath = BP . DS . 'vendor';
    }
}
require $autoloaderPath . DS . 'autoload.php';
/** AUTOLOADER PATCH **/

from magento-lts.

ferdiusa avatar ferdiusa commented on June 20, 2024

This issue can be replicated if the .htaccess inside the media/ directory is properly parsed. (this actually redirects all request through get.php)
Some apache configurations skip this (and use the /.htaccess instead of /media/.htaccess for files in subdirectories). Try accessing
http://openmage.test/media/missingfile.jpg
This should result in error 500 instead of 404 due to the missing class (due to missing autoloader patch in get.php)

from magento-lts.

ADDISON74 avatar ADDISON74 commented on June 20, 2024

@ferdiusa - that is a good observation. I tested this reported before and I got error 500, without anything in the webserver logs. Some testers reported above getting 404 error.

from magento-lts.

S0FTWEX avatar S0FTWEX commented on June 20, 2024

Error 500 can be fixed by adding

<IfModule mod_php8.c>
    php_flag engine 0
</IfModule>

in media/.htaccess. This fix actually redirects all request through get.php, but there is still problem with missing class Zend_Controller_Request_Http.

from magento-lts.

fballiano avatar fballiano commented on June 20, 2024

I hope #3476 fix this problem ;-)

from magento-lts.

S0FTWEX avatar S0FTWEX commented on June 20, 2024

I hope #3476 fix this problem ;-)

Yes, this PR fixes the problem.

from magento-lts.

fballiano avatar fballiano commented on June 20, 2024

@S0FTWEX could you leave a review with the green button on the top-left https://github.com/OpenMage/magento-lts/pull/3476/files? thanxxxx

from magento-lts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.