Odd conversion from string to number - multiply by one about magento-lts HOT 9 CLOSED

I do expect postcode to be a number :)
(I do use number to be able to search from/to postcodes)

There was cases of whitespace included in value, customers who had written postcode in city and vice versa, in customer profile address (my fault).
But that isn't my point with this issue.

To my knowledge, the only reason to multiply the value with 1, is to make sure a string is converted to a number?
So i believe that either it should expect a number or convert in a better way, or handle an exception?

from magento-lts.

There are many places that can throw

TypeError: Unsupported operand types: string * int :

that need to be fixed as well.

app\code\core\Mage\Adminhtml\Block](

from magento-lts.

If your postcode is not a number, why do you set 'type' => 'number'?

from magento-lts.

Can you do a PR?

from magento-lts.

Can you do a PR?

Yeah, I'll have a go at it and submit a PR :)

Ref:
https://github.com/search?q=repo%3AOpenMage%2Fmagento-lts+%22+*+1%3B%22&type=code
https://github.com/search?q=repo%3AOpenMage%2Fmagento-lts+%22+*+1+%22&type=code

from magento-lts.

Please do not change.

You can add a custom column renderer, observe _before_save or _after_load, validate input ... no need to change core for some wrong input.

from magento-lts.

I don't want to change core due to wrong input - i found the odd number conversion code due to wrong input handling.
If the mentioned core code is not an issue, i'll just close it.

from magento-lts.

You can try: https://onlinephp.io?s=s7EvyCjg5VIpLilSsFVQN1S35uUqSyyKTynNLdAAi2orGGhaAwA%2C&v=8.2.12

$number = '1' * 1; // int(1)
$number = '1.01' * 1; // float(1.01)
$number = 'str' * 1; // Fatal error: Uncaught TypeError: Unsupported operand types: string * int

Is it wrong to throw the last error? It depends on the use case. For

In the core, the above code is used for column of type int as defined in the DB. So it's probably ok to throw an error, I think. So I changed the label to "bug unconfirmed".

from magento-lts.

Sounds right.
I'll close it up.

from magento-lts.