Giter VIP home page Giter VIP logo

Comments (16)

ImreSamu avatar ImreSamu commented on May 23, 2024 2

The iD Editor has a lot of metadata , maybe we can reuse ..

examples:

They have categories: https://github.com/openstreetmap/iD/tree/master/data/presets/categories
and depracated lists ( to replace old taggings ) https://github.com/openstreetmap/iD/blob/master/data/deprecated.json

from openmaptiles.

lukasmartinelli avatar lukasmartinelli commented on May 23, 2024 1

For me the preferred document format is .csv ( can be read and edit with Excel /Libreoffice )

Well we could build support for this in openmaptiles-tools..and then generate functions (this code already exists for generating).

from openmaptiles.

lukasmartinelli avatar lukasmartinelli commented on May 23, 2024 1

if you think my proposal is reasonable. I would like to assigning the OSM tags into these buckets .and of course i will enrich the classification and the rank. it will contain information about traffic and other important information.

Go for it!!

could you give me the link about the tags of the OSM POI tags? I don't know which is the exactly correct one.

http://wiki.openstreetmap.org/wiki/Points_of_interest

A good resource is the Geofabrik paper on how to structure OSM tags (Chapter 4.2):
https://www.geofabrik.de/data/geofabrik-osm-gis-standard-0.6.pdf

from openmaptiles.

sfkeller avatar sfkeller commented on May 23, 2024 1

There's also https://github.com/simonpoole/beautified-JOSM-preset .

But let me insist in this: Did anybody look at ? https://github.com/geometalab/osmaxx/blob/develop/docs/osmaxx_data_schema.md#poi_p and the data schema of our OSMaxx project? OSMaxx is focussing on basemaps and analysis in GIS. But with basemaps from OSM data the two projects share a goal, so they can benefit from each other.

from openmaptiles.

lukasmartinelli avatar lukasmartinelli commented on May 23, 2024

I would be ok with these additional categories (1st and 2nd class). Certainly makes it easier
to assign the same icon to same classes than now.

The big work however is assigning the OSM tags into these buckets (100+tags).
Would welcome such work. I don't have strong opinions for the POI layer right now - just important that there is a ranking and perhaps later on also make it possible to put important landmarks and transport POIs into the layer.

poi_classification

from openmaptiles.

ImreSamu avatar ImreSamu commented on May 23, 2024

I like the idea of storing all information ( business logic ) in the single metadata for the POI layer ..
because - we separate to logic with the codes .. and it is easy to understand for the users

For me the preferred document format is .csv ( can be read and edit with Excel /Libreoffice )

Tilezen using similar metadata in excel :

from openmaptiles.

lukasmartinelli avatar lukasmartinelli commented on May 23, 2024

I like the idea of storing all information ( business logic ) in the single metadata for the POI layer ..
because - we separate to logic with the codes .. and it is easy to understand for the users

Well yes..but then on the other hand it can be just as confusing where it now comes from.
We had it in a YAML file before but I put it into SQL to make it very explicit where it is defined.

See osm2vectortiles/osm2vectortiles#470.

from openmaptiles.

ImreSamu avatar ImreSamu commented on May 23, 2024

I like - If we can move all information to a single .csv file , ( in the future )

  • but this is not a quick task
  • and need a lot of design time ( for a good architecture ) and integrating to openmaptiles-tools

but I add here my ideas :

probably we can add a rank and classification metadata to this document

And we can extend with maki icon names ..

And ( later ) we can add ( Y/N ) columns about thematic layers or styles

So we can create more slim POI layers ( removing the unwanted POI-s ) by automatically ...

from openmaptiles.

lukasmartinelli avatar lukasmartinelli commented on May 23, 2024

probably we can add a rank and classification metadata to this document

Having more detailed ranking in a CSV is fine.
One could also use ordered SQL types.

And we can extend with maki icon names ..

I don't want to have support for maki icons in OpenMapTiles since this is really Mapbox specific.
What one can always do is rename the open Maki icon set to fit the classes/types of the POIs when designing a style.

This way one can use the Maki icon set but does not use the potentially copyrighted (imho you cannot do that) mapping from tags to Maki icons

from openmaptiles.

bearnxx avatar bearnxx commented on May 23, 2024

@lukasmartinelli @ImreSamu

big work however is assigning the OSM tags into these buckets (100+tags).

if you think my proposal is reasonable. I would like to assigning the OSM tags into these buckets .and of course i will enrich the classification and the rank. it will contain information about traffic and other important information.

could you give me the link about the tags of the OSM POI tags? I don't know which is the exactly correct one.

from openmaptiles.

ImreSamu avatar ImreSamu commented on May 23, 2024

@bearnxx :

probably you can use the OSM Taginfo statistics
like:

Extreme example :)

The ice_cream can be tagged more ways : http://taginfo.openstreetmap.org/search?q=ice_cream#values

  • 9 067 : cuisine=ice_cream
  • 8 780 : amenity=ice_cream
  • 1 743 : shop=ice_cream

But checking with the Overpass ( “cuisine=ice_cream in iceland” ) http://overpass-turbo.eu/s/kaS
most of them

  • amenity=cafe + cuisine=ice_cream
  • amenity=fast_food + cuisine=ice_cream
  • amenity=restaurant + cuisine=ice_cream

So only this 2 tagging version we can use :

  • amenity=ice_cream
  • shop=ice_cream

important

You can download the taginfo data http://taginfo.openstreetmap.org/download ( Sqlite databases )

  • and it is easy to export to .csv file and import this to your working excel ( as a new schema )
    • need a minimal sql knowledge

And please read my review ( #15 ) , it was based on Taginfo

if you finished the first 5-10% please show us , and we can review ...
( or you can use https://docs.google.com/spreadsheets/ and share a link .. )

from openmaptiles.

sfkeller avatar sfkeller commented on May 23, 2024

See also our work on structuring POIs and others in our OSMaxx project https://github.com/geometalab/osmaxx/blob/develop/docs/osmaxx_data_schema.md#poi_p

from openmaptiles.

bearnxx avatar bearnxx commented on May 23, 2024

Get it! @ImreSamu @lukasmartinelli @sfkeller

from openmaptiles.

lukasmartinelli avatar lukasmartinelli commented on May 23, 2024

The iD Editor has a lot of metadata , maybe we can reuse ..

Yup I like that one very much (given it is not close to maki of Mapbox - have not checked that).

from openmaptiles.

ImreSamu avatar ImreSamu commented on May 23, 2024

@lukasmartinelli

Yup I like that one very much (given it is not close to maki of Mapbox - have not checked that).

it is easy to check :)
https://github.com/openstreetmap/iD/search?utf8=%E2%9C%93&q=maki

from openmaptiles.

bearnxx avatar bearnxx commented on May 23, 2024

I‘m a little busy recently. I have added some new class in the POI schema. look at the excel

github don't support csv file for attachment. so I upload xlsx instead.
what class can we add to the file?

@lukasmartinelli @ImreSamu @klokan @nvkelso

POI_Classification.xlsx

from openmaptiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.