NPE when missing object is not helpful to users about jenkins-client-plugin HOT 3 CLOSED

OK, some initial triage:

1. the NPE literally stems from the currentContext being null

2. the version of OpenShiftDSL.groovy that @stevekuznetsov is at here, based on the line numbers, and the fact that _asSingeMap calls buildCommonArgs is relatively old. We are talking about commit 7a0dc00 which is 10 weeks ago as of this comment.

buildCommonArgs is no longer called from _asSingleMap since @jupierce changed how _asSingleMap works with commit 170b9d2 two weeks ago.

Now, what to do:

• prior to @jupierce 's 170b9d2, this smelled like the need for another use of dieIfWithout, checking on currentContext

• but with this refactor, including the returning of an empty list on object() if we are not pointing to anything, I am going to close this ("fixed upstream" or however you are inclined to phrase it).

@stevekuznetsov - I plan on cutting a new version of the client plugin (v1.0.4) in the next day or two once I've finished triaging all the "week before Christmas" Jenkins fun that ensued while I was on PTO. It should pick up @jupierce 's commits during that time, including the one I've referenced above. And then I'll update the openshift jenkins centos image right after.

Let's see if you still see this after picking either that image or the latest plugin.

from jenkins-client-plugin.

@gabemontero buildCommonArgs might be a good place to a die-without-context in general. It would eliminate this error from other codepaths.

from jenkins-client-plugin.

from jenkins-client-plugin.