Comments (5)
Using OSE 3.1.1 (Jenkins plugin 1.0.4), demobuilder image.
In https://github.com/openshift/jenkins-plugin/blob/master/src/main/java/com/openshift/jenkins/plugins/pipeline/Auth.java#L86 , shouldn't
if (this.listener.getLogger() != null)
read
if (this.listener != null)
?
from jenkins-plugin.
ATM not quite sure why I'm hitting this bug and others don't appear to have done. The pod was created via using the jenkins-ephemeral instant app.
from jenkins-plugin.
Ah, FWIW this triggers if the OpenShift node cert is missing the chained CA certificate.
from jenkins-plugin.
hey @jim-minter - yep, you have basically captured the 2 key points here. But I'll elaborate a bit:
-
Yes, the if check at https://github.com/openshift/jenkins-plugin/blob/master/src/main/java/com/openshift/jenkins/plugins/pipeline/Auth.java#L86 should be changed as you articulated; the Auth class uses the setting of the listener instance var to dictate whether it does verbose logging or not (there are some scenarios where the "verbose" flag set on the build steps is not accessible); easy enough fix I'll put in the queue
-
Your point about that the OpenShift node cert is missing is the key to why others haven't seen it as yet; to date, users have had that set up, and we've not allowed insecure connections with the plugin; to that end, even without the NPE, your job would have ultimately failed, citing a failed SSL negotiation ... at the moment, we allow insecure access if the plugin is not running out of our jenkins image, but if we are running out of the jenkins image, we currently require it.
Let me know your take on allowing insecure access. There has been some back and forth about whether to allow insecure access (the kube plugin from cloudbees does for example), importing of certs, etc. So the plugin may be getting enhanced here.
But in the short term, I'll get the NPE fix in the queue.
from jenkins-plugin.
just pushed the NPE fix to this repo with commit 4b98d9c.
marking this item closed; i'm following up with @jim-minter outside of this issue on some additional jenkins plugin / image updates
from jenkins-plugin.
Related Issues (20)
- Patch / Update resources HOT 9
- jenkins template using spec.clusterIP instead of spec.portalIP HOT 2
- Build output sometimes not shown in jenkins console output HOT 2
- Deployments don't work HOT 3
- Environment Variables don't respect Parameterised Builds HOT 6
- Timeout of builds HOT 3
- Unable to do openshiftTag() in pipeline HOT 1
- FR: Support of variables inside Openshift Exec HOT 9
- BUG: "Test connection" always returns "Connections successful" HOT 11
- BUG: OpenshiftExec ignores timeout HOT 12
- Confusing print statement if openshiftVerifyDeployment fails HOT 1
- okhttp binary changes break plugin when others installed HOT 11
- Externalize the CERT_FILE = "/run/secrets/kubernetes.io/serviceaccount/ca.crt"; HOT 7
- Issue with Jenkin's Verify Build OpenShift plug-in functionality HOT 9
- Declarative pipeline support? HOT 4
- openshift-client-plugin really still a "tech preview" ? HOT 3
- Jenkins throws an error when using the openhiftBuild with the buildConfig parameter HOT 3
- Resulting GDSL is Broken HOT 2
- openshiftBuild should support binary build type. HOT 10
- Add deprecation warning and link to new plugin as first thing in repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jenkins-plugin.