NullPointerException in com.openshift.jenkins.plugins.pipeline.Auth.allowCertificate(Auth.java:86) about jenkins-plugin HOT 5 CLOSED

Using OSE 3.1.1 (Jenkins plugin 1.0.4), demobuilder image.

In https://github.com/openshift/jenkins-plugin/blob/master/src/main/java/com/openshift/jenkins/plugins/pipeline/Auth.java#L86 , shouldn't

if (this.listener.getLogger() != null)

read

if (this.listener != null)

?

from jenkins-plugin.

ATM not quite sure why I'm hitting this bug and others don't appear to have done. The pod was created via using the jenkins-ephemeral instant app.

from jenkins-plugin.

Ah, FWIW this triggers if the OpenShift node cert is missing the chained CA certificate.

from jenkins-plugin.

hey @jim-minter - yep, you have basically captured the 2 key points here. But I'll elaborate a bit:

1. Yes, the if check at https://github.com/openshift/jenkins-plugin/blob/master/src/main/java/com/openshift/jenkins/plugins/pipeline/Auth.java#L86 should be changed as you articulated; the Auth class uses the setting of the listener instance var to dictate whether it does verbose logging or not (there are some scenarios where the "verbose" flag set on the build steps is not accessible); easy enough fix I'll put in the queue

2. Your point about that the OpenShift node cert is missing is the key to why others haven't seen it as yet; to date, users have had that set up, and we've not allowed insecure connections with the plugin; to that end, even without the NPE, your job would have ultimately failed, citing a failed SSL negotiation ... at the moment, we allow insecure access if the plugin is not running out of our jenkins image, but if we are running out of the jenkins image, we currently require it.

Let me know your take on allowing insecure access. There has been some back and forth about whether to allow insecure access (the kube plugin from cloudbees does for example), importing of certs, etc. So the plugin may be getting enhanced here.

But in the short term, I'll get the NPE fix in the queue.

from jenkins-plugin.

just pushed the NPE fix to this repo with commit 4b98d9c.

marking this item closed; i'm following up with @jim-minter outside of this issue on some additional jenkins plugin / image updates

from jenkins-plugin.