Giter VIP home page Giter VIP logo

Comments (7)

gabemontero avatar gabemontero commented on July 19, 2024

Yep, that is how the var substitution for the steps works. My prior testing though had lead me to believe a new instance of the step was instantiated. Obviously appears otherwise.

Have an idea on how to reconcile (an alternative approach I had originally considered). I may be able to start as soon as tomorrow on it.

from jenkins-plugin.

elyscape avatar elyscape commented on July 19, 2024

I don't know exactly how it's done, but a lot of other plugins support parameter expansion. For example, the CloudBees Docker Build and Publish plugin:

parameter expansion

from jenkins-plugin.

elyscape avatar elyscape commented on July 19, 2024

Update: looks like it's done by using the Token Macro plugin.

from jenkins-plugin.

gabemontero avatar gabemontero commented on July 19, 2024

Thanks for the pointer, though in looking at the token macro code and the example usage from a couple of plugins, it won't serve as a total plug in play replacement for the current code. That said, we may want to leverage it (either as part of this fix, or future enhancements).

from jenkins-plugin.

gabemontero avatar gabemontero commented on July 19, 2024

@elyscape : I've delievered the fix for this with commit dfecb8e to this repo.

Also, if you would not rather build the plugin hpi file yourself to try it out, you can obtain a built plugin hpi file with this fix at https://ci.openshift.redhat.com/jenkins/job/openshift-pipeline-plugin/lastBuild/artifact/plugin/openshift-pipeline.hpi

Otherwise, if you are going to wait for a new OpenShift Jenkins image getting built with a plugin update with this fix, it may be a few weeks before we do that (though something earlier is not necessarily out of the question).

But if you can try it out beforehand, that would be awesome, and of course reopen this issue / open new issues as needed.

thanks

from jenkins-plugin.

elyscape avatar elyscape commented on July 19, 2024

Just tried it out and it looks good to me. Thanks for your help!

from jenkins-plugin.

gabemontero avatar gabemontero commented on July 19, 2024

Cool deal! Thanks for trying it out and confirming!

On Thu, Mar 10, 2016 at 5:30 PM, Eli Young [email protected] wrote:

Just tried it out and it looks good to me. Thanks for your help!


Reply to this email directly or view it on GitHub
#26 (comment)
.

from jenkins-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.