Comments (7)
Yep, that is how the var substitution for the steps works. My prior testing though had lead me to believe a new instance of the step was instantiated. Obviously appears otherwise.
Have an idea on how to reconcile (an alternative approach I had originally considered). I may be able to start as soon as tomorrow on it.
from jenkins-plugin.
I don't know exactly how it's done, but a lot of other plugins support parameter expansion. For example, the CloudBees Docker Build and Publish plugin:
from jenkins-plugin.
Update: looks like it's done by using the Token Macro plugin.
from jenkins-plugin.
Thanks for the pointer, though in looking at the token macro code and the example usage from a couple of plugins, it won't serve as a total plug in play replacement for the current code. That said, we may want to leverage it (either as part of this fix, or future enhancements).
from jenkins-plugin.
@elyscape : I've delievered the fix for this with commit dfecb8e to this repo.
Also, if you would not rather build the plugin hpi file yourself to try it out, you can obtain a built plugin hpi file with this fix at https://ci.openshift.redhat.com/jenkins/job/openshift-pipeline-plugin/lastBuild/artifact/plugin/openshift-pipeline.hpi
Otherwise, if you are going to wait for a new OpenShift Jenkins image getting built with a plugin update with this fix, it may be a few weeks before we do that (though something earlier is not necessarily out of the question).
But if you can try it out beforehand, that would be awesome, and of course reopen this issue / open new issues as needed.
thanks
from jenkins-plugin.
Just tried it out and it looks good to me. Thanks for your help!
from jenkins-plugin.
Cool deal! Thanks for trying it out and confirming!
On Thu, Mar 10, 2016 at 5:30 PM, Eli Young [email protected] wrote:
Just tried it out and it looks good to me. Thanks for your help!
—
Reply to this email directly or view it on GitHub
#26 (comment)
.
from jenkins-plugin.
Related Issues (20)
- Patch / Update resources HOT 9
- jenkins template using spec.clusterIP instead of spec.portalIP HOT 2
- Build output sometimes not shown in jenkins console output HOT 2
- Deployments don't work HOT 3
- Environment Variables don't respect Parameterised Builds HOT 6
- Timeout of builds HOT 3
- Unable to do openshiftTag() in pipeline HOT 1
- FR: Support of variables inside Openshift Exec HOT 9
- BUG: "Test connection" always returns "Connections successful" HOT 11
- BUG: OpenshiftExec ignores timeout HOT 12
- Confusing print statement if openshiftVerifyDeployment fails HOT 1
- okhttp binary changes break plugin when others installed HOT 11
- Externalize the CERT_FILE = "/run/secrets/kubernetes.io/serviceaccount/ca.crt"; HOT 7
- Issue with Jenkin's Verify Build OpenShift plug-in functionality HOT 9
- Declarative pipeline support? HOT 4
- openshift-client-plugin really still a "tech preview" ? HOT 3
- Jenkins throws an error when using the openhiftBuild with the buildConfig parameter HOT 3
- Resulting GDSL is Broken HOT 2
- openshiftBuild should support binary build type. HOT 10
- Add deprecation warning and link to new plugin as first thing in repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jenkins-plugin.