obs-service-python_sdist's Introduction

Python setup.py sdist service

This service creates a source distribution (sdist) from a Python project (containing a setup.py file)

Example _service file:

<services>
  <service name="tar_scm" mode="disabled">
    <param name="url">git://github.com/kwwii/horizon.git</param>
    <param name="scm">git</param>
    <param name="package-meta">.git</param>
    <param name="versionformat">1.0.0</param>
    <param name="revision">grizzly-suse-ui</param>
  </service>
  <service name="python_sdist" mode="disabled">
    <param name="basename">horizon-*.tar</param>
  </service>
</services>

obs-service-python_sdist's People

Contributors

Stargazers

Watchers

obs-service-python_sdist's Issues

nobody should use this

Reasons:

It is technically a build step and for some packages it is also in a practical sense a build step as it changes the source enough to make it noticeably not the preferred form of modification. Thus it is not a source acquire step, but OBS source services are meant for source acquire and prepare steps.
This needs the full build time requirements available for whatever setup.py does. An OBS server usually won't have these.
It violates the isolation that is usually demanded of building packages: Either have access to download from the internet or run code from the source package for building, but not both at the same time. OBS source services should not run code from the package.

Original author didn't respond. And it was said by an admin of this org that it wasn't OK to just merge PRs in the repo, otherwise I would also edit this repos Readme.

Exception raised when basename is a directory

When basename is set to a directory with a working copy, the following exception is raised:

Cloning into '/home/jesusaur/local/var/osc/home:jesusaur:socok8s/python3-armada/armada'...
54406d8f96bad9682ffc0c878423a5e0bddfc51a
Traceback (most recent call last):
  File "/usr/lib/obs/service/python_sdist", line 61, in <module>
    if tarfile.is_tarfile(args.basename):
  File "/usr/lib64/python2.7/tarfile.py", line 2624, in is_tarfile
    t = open(name)
  File "/usr/lib64/python2.7/tarfile.py", line 1675, in open
    return func(name, "r", fileobj, **kwargs)
  File "/usr/lib64/python2.7/tarfile.py", line 1740, in gzopen
    fileobj = gzip.GzipFile(name, mode, compresslevel, fileobj)
  File "/usr/lib64/python2.7/gzip.py", line 94, in __init__
    fileobj = self.myfileobj = __builtin__.open(filename, mode or 'rb')
IOError: [Errno 21] Is a directory: 'armada'

Which seems to be missing this else

Recommend Projects