opentok / accelerator-textchat-android Goto Github PK

Expected behavior

The ReadMe document says while initializing OTAcceleratorSession object pass parameters in this sequence

OTAcceleratorSession mSession = new OTAcceleratorSession (context, sessionId, apikey);

Actual behavior

While the actual defination requires the parameters to be passed in this is sequence

OTAcceleratorSession mSession = new OTAcceleratorSession(context, apiKey, sessionId) ;

The position of apiKey and sessionId parameters is swapped. It wasted my entire day.

...

New issue checklist

• I have read all of the README
• I have searched existing issues and this is not a duplicate.

General information

• Library version(s):
• iOS/Android/Browser version(s):
• Devices/Simulators/Machine affected:
• Reproducible in the demo project? (Yes/No):
• Related issues:

Bug report

Currently, we are using notifyadatper() method to update recyclerview which is prone to destroy existing rendered views and recreate all the views.

Expected behavior

The accelerator textchat should render only needed views

Actual behavior

Right now, we are using notify adapter to update and render recycler view

Steps to reproduce

...

Crash log? Screenshots? Videos? Sample project?

...

Question or Feature Request

This is Enhancement

New issue checklist

• I have read all of the README
• I have searched existing issues and this is not a duplicate.

General information

• Library version(s): 1.0.2
• iOS/Android/Browser version(s): Android
• Devices/Simulators/Machine affected:
• Reproducible in the demo project? (Yes/No): Yes
• Related issues:

Bug report

The session in the constructor is not connected. Manage a disconnected session from the accelerator textchat

Expected behavior

The accelerator textchat should detect if the session is connected or not, and it should manage it.

Actual behavior

Right now, we are supposing the session is connected from the app before to start sending/receiving messages.

Steps to reproduce

...

Crash log? Screenshots? Videos? Sample project?

...

Question or Feature Request

...

D/OTAcceleratorSession: internalSendSignal: text-chat
D/OTAcceleratorSession: Dispatching signal: text-chat with: {"sender":{"id":"7f8cd9f6-e179-43ca-be3a-5485ab0098e3","alias":"Tokboxer"},"text":"High","sentOn":1599823638979}
dispatchSignal: No global listeners registered for: text-chat
Starting thread to process: text-chat : {"sender":{"id":"7f8cd9f6-e179-43ca-be3a-5485ab0098e3","alias":"Tokboxer"},"text":"High","sentOn":1599823638979}
D/OTAcceleratorSession: Dispatching signal: text-chat : {"sender":{"id":"7f8cd9f6-e179-43ca-be3a-5485ab0098e3","alias":"Tokboxer"},"text":"High","sentOn":1599823638979} on thread: 6709
I/text-chat-message: status: SENT_MESSAGE
D/Fragment: onNewSentMessage
I/VideoChatActivity: New sent message
I/Fragment: New message High is ready to be added.

D/OTAcceleratorSession: Dispatching signal: msg with: sadas
D/OTAcceleratorSession: dispatchSignal: No global listeners registered for: msg
dispatchSignal: No listeners registered for: msg

New issue checklist

• [x ] I have read all of the README
• [x ] I have searched existing issues and this is not a duplicate.

General information

• Library version(s):
  implementation 'com.opentok.android:opentok-accelerator-core:1.0.21'
  implementation 'com.opentok.android:opentok-accelerator-textchat:1.0.4'
• iOS/Android/Browser version(s): Android 7, probably others
• Devices/Simulators/Machine affected: Galaxy S7
• Reproducible in the demo project? (Yes/No): (not tried)
• Related issues:

Bug report

Getting a crash report from Crashlytics
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Context.getPackageName()' on a null object reference

Expected behavior

Open text chat and use normally

Actual behavior

Crash

Steps to reproduce

unk. but code does not null-check the getContext() call which can return null in certain situations.

Crash log? Screenshots? Videos? Sample project?

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Context.getPackageName()' on a null object reference
at com.tokbox.android.accpack.textchat.TextChatFragment.init(TextChatFragment.java:345)
at net.theretrocompany.android.retrobeauty.ConsultationSession$3.onConnected(ConsultationSession.java:516)
at net.theretrocompany.android.retrobeauty.ConsultationSession$3.onConnected(ConsultationSession.java:502)
at com.tokbox.android.otsdkwrapper.listeners.PausableBasicListener$2.run(PausableBasicListener.java:62)
at com.tokbox.android.otsdkwrapper.listeners.PausableBasicListener$1.run(PausableBasicListener.java:48)
at com.tokbox.android.otsdkwrapper.listeners.PausableBasicListener.runUIListenerTask(PausableBasicListener.java:53)
at com.tokbox.android.otsdkwrapper.listeners.PausableBasicListener.onConnected(PausableBasicListener.java:59)
at com.tokbox.android.otsdkwrapper.wrapper.OTWrapper$1.onConnected(OTWrapper.java:1074)
at com.tokbox.android.otsdkwrapper.wrapper.OTAcceleratorSession.onConnected(OTAcceleratorSession.java:312)
at com.opentok.android.Session$3.run(Session.java:1461)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6688)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1468)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358)

Question or Feature Request

...