Hi there, I was curious why in parser this was done:

type ParsedComponent struct {
    Label string `json:"label"`
    Value string `json:"value"`
}

    for i = 0; i < numComponents; i++ {
        parsedComponents[i] = ParsedComponent{
            Label: C.GoString(cLabelsPtr[i]),
            Value: C.GoString(cComponentsPtr[i]),
        }
    }

This is pretty hard to use in a practical setting. I found that the only way I could really use this was to convert it to a map[string]string and access it that way.

Wouldn't it be more reasonable to do this?

type PasedComponents map[string]string

// ...
for i = 0; i < numComponents; i++ {
    pasedComponents[C.GoString(cLabelsPtr[i])] = C.GoString(cComponentsPtr[i])
}

If I try to expand an address:

terms := expand.ExpandAddress("1234 Sesame St. New York, NY 12345")

I get the following strings returned:

[
  "%d string=12345 sesame saint new york ny 12345 to id 1234",
  "%d string=12345 sesame saint new york new york 12345 to id 1234",
  "%d string=12345 sesame street new york ny 12345 to id 1234",
  "%d string=12345 sesame street new york new york 12345 to id 1234",
  "%drive string=12345 sesame saint new york ny 12345 to id 1234",
  "%drive string=12345 sesame saint new york new york 12345 to id 1234",
  "%drive string=12345 sesame street new york ny 12345 to id 1234",
  "%drive string=12345 sesame street new york new york 12345 to id 1234"
]

I would expect to just return the first 4 strings without the %d string= in front. What is the purpose of that prefix?

I'm using go18.1 and version v0.0.0-20171226154602-e0184512a45d of gopostal

I have installed on Windows the lib and wanted to use this binding, but without any success.

Created a fresh go mod using go 1.20 and copy pasted readme example.
the IDE (vs code with Go extension) says
could not import github.com/openvenues/gopostal/expand (no required module provides package "github.com/openvenues/gopostal/expand")

And while trying to run:
github.com/openvenues/gopostal/expand: build constraints exclude all Go files in ...\go\pkg\mod\github.com\openvenues\[email protected]\expand

Any helps or hints appreciated.

Tried many things so far on my mac osX trying to build to ubuntu: GOOS=linux GOARCH=amd64 go build:

pkg-config --libs --cflags libpostal
-I/usr/local/include -L/usr/local/lib -lpostal

ls /usr/local/lib | grep libpostal
libpostal.1.dylib
libpostal.a
libpostal.dylib
libpostal.la

Common issue seems to be when I run:

CGO_ENABLED=1 GOOS=linux GOARCH=amd64 go build -o fmaplX main.go give this:

ld: unknown option: --build-id=none
clang: error: linker command failed with exit code 1 (use -v to see invocation)

with CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o fmaplX main.go

go build github.com/PartnerFusionInc/cable/fmap/vendor/github.com/openvenues/gopostal/expand: no buildable Go source files in /Users/jbowles/gowork/src/github.com/PartnerFusionInc/cable/fmap/vendor/github.com/openvenues/gopostal/expand
go build github.com/PartnerFusionInc/cable/fmap/vendor/github.com/openvenues/gopostal/parser: no buildable Go source files in /Users/jbowles/gowork/src/github.com/PartnerFusionInc/cable/fmap/vendor/github.com/openvenues/gopostal/parser

Here is my clang:

clang --version                                                                                                                     1 ↵ ‹2.4.1›
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

And by go env

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jbowles/gowork"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0_/f4vhytgs455crcjlzfc9dy8h0000gn/T/go-build099799126=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

Are the labels in all of the parsed address components unique for a single address? If so, it might be useful to create a type on ParsedComponent[] that can convert to and from a map, and marshall and unmarshall JSON.

parser.ParseAddress() is not multicore. I'm trying to parse a large dataset and this is severely hurting my performance.

We are currently using the gopostal library in a webserver application. Upon receiving an HTTP request from a client, the app will use gopostal to parse the address included in the client's request and return the parsed components. However, during our heavy load testing (and only during such testing), we are seeing the underlying libpostal library throwing segmentation violations, which in turn is crashing the entire application. Weirdly enough, the app works just fine during normal traffic.

Apologies if this is the wrong medium for this question but i'm at a wall. I'm getting inconsistent parsing results in my environments that is making it difficult to debug.

For example this address (it's a fake street address but real city, state, and zip) parses incorrectly in my docker instance(debian), but if i were to run it locally (m1 macos) it would parse correctly.

1111 main street, Chapel Hill, North Carolina 27516

It seems to confuse the state North Carolina and appends North to the city value:

{
    "label": "house_number",
    "value": "1111"
},
{
    "label": "road",
    "value": "main street"
},
{
    "label": "city",
    "value": "chapel hill north"
},
{
    "label": "state",
    "value": "carolina"
},
{
    "label": "postcode",
    "value": "27516"
}

While in another instance,

{
    "label": "house_number",
    "value": "1111"
},
{
    "label": "road",
    "value": "main street"
},
{
    "label": "city",
    "value": "chapel hill"
},
{
    "label": "state",
    "value": "north carolina"
},
{
    "label": "postcode",
    "value": "27516"
}

They're consistent in their environment, i have not re-compiled my local (correctly parsing) instance but both the docker instance and my local instance are using the same forked version of Libpostal when compiling and configuring/setting up.

I imagine this is an open ended and hard to answer question, but im wondering if this has been seen before and would appreciate just any insight into why they're different results and why it's not recognizing the state. Thanks in advance .

Just the title :) apt is just newer apt-get