Giter VIP home page Giter VIP logo

ovos-skill-laugh's Issues

dont laugh over speak

when random laughing there is a chance the sound will play over speech

TODO: add wait_while_speaking before playing laugh

evil laugh - "sample format not available"

When I want it to laugh evily, there comes this error

 03:18:20.662 | INFO     |  3214 | QuestionsAnswersSkill | Searching for kannst du böse lachen
Removing event fallback-query.mycroftai:QuestionQueryTimeout
Removing event fallback-query.mycroftai:QuestionQueryTimeout
Removing event fallback-query.mycroftai:QuestionQueryTimeout
Removing event fallback-query.mycroftai:QuestionQueryTimeout
 03:18:22.064 | INFO     |  3214 | QuestionsAnswersSkill | Timeout occured check responses
Playing WAVE '/opt/mycroft/skills/laugh.jarbasal/sounds/male/Evil_Laugh_Male_6-Himan-1359990674.wav' : Float 32 bit Little Endian, Rate 48000 Hz, Stereo
aplay: set_params:1339: Sample format non available
Available formats:
- U8
- S16_LE
  ^--- NEWEST ---^

use audio service

only .wav files are supported, audio service makes it much more flexible

TODO: use audio service to allow any kind of file format

replace images

all images should be replaced with something with proper licensing

laugh may be interrupted by speech

mycroft should stop laughing and not speak over the laugh

TODO: listen for speak messages and stop the laugh sound when this happens

#3 makes this easier, however we need a mechanism to query audio service for path of currently playing file, to ensure we don't terminate every audio stream, only terminate laughs

Make tagged releases

Hey, thanks for this skill!

I've been packaging Mycroft for Alpine Linux (which I think is the first distribution to do so) and am currently packaging all the different skills available. The idea is to make all skills available as distro packages and not use the current Mycroft marketplace and Pip to install them. I'd love to package your skill as well, but will need a tagged (git tag) release to do so.

Please consider making tagged release so that distributions like Alpine Linux and in the future others can package them and keep track of updates.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.