Giter VIP home page Giter VIP logo

Comments (2)

yaronvel avatar yaronvel commented on June 9, 2024 1

hey, i agree that EIP-1967 has better rational. But after you mentioned it i see that EIP 1822 is allowing to change it. So I am closing this issue. Thanks for the quick response.

from openzeppelin-contracts.

ernestognw avatar ernestognw commented on June 9, 2024

Hi @yaronvel, quick note:

EIP 1882 was never approved,

EIPs are not "approved". It's the author's responsibility to finalize them and gather community consensus. EIPs may become stagnant but can be picked up by anyone in the community if they think it's valuable to move it forward.

Now on the issue:

EIP 1822 never enforces the use of keccak256("PROXIABLE") as storage location. In fact, the proxiable specification suggests to change it:

proxiable
Compatibility check to ensure the new Logic Contract implements the Universal Upgradeable Proxy Standard. Note that in order to support future implementations, the bytes32 comparison could be changed e.g., keccak256("PROXIABLE-ERC1822-v1").

The storage location is thought to not collide with regular storage locations derived by Solidity variables. However, EIP-1967 has shown a better rationale for this, and similarly for EIP-7201, so using any of both is still within the EIP-1822 boundaries.

As EIP1882 is stagnated, maybe it is just best to remove it from your codebase and avoid confusion.

Being stagnant doesn't mean is not still useful and widely adopted.
Would you mind clarifying how you think this is confusing and if it's causing an issue to our users?

from openzeppelin-contracts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.