Comments (1)
ernestognw
commented on June 9, 2024
Hey @yaronvel, it's not clear what is not being enforced since the EIP paragraph you're quoting references multiple things. Given the title of the issue, I'll assume you're arguing that the address in the admin slot is not enforced to be the only upgrader.
As you may notice, the EIP doesn't use "MUST" in the sentence and is also very clear about it being optional:
Holds the address that is allowed to upgrade the logic contract address for this proxy (optional).
Yet, both references are incomplete. The first is a virtual function with instructions to override and the second is an internal function in a library (i.e. not exposed publicly and frequently wrapped with some sort of access control). It's the developer's responsibility to keep the allowed upgrader address in the corresponding slot and emit its events, though it's not enforceable and therefore strongly suggested with:
Changes to this slot SHOULD be notified by the event
Closing. Feel free to ask questions in our community forum, but please review our support standards
from openzeppelin-contracts.
Related Issues (20)
- Fixing "Invalid OpCode" Truffle Error with Openzeppelin Library Installed HOT 6
- ERC20 _update customization is not practical. HOT 17
- Consider changing `memory-safe` NatSpec annotations to `assembly('memory-safe')` dialect string HOT 3
- A new utility contract to enhances the security of deploying and managing upgradable contracts in Hardhat plugin.
- A new utility contract to enhances the security of deploying and managing upgradable contracts in Hardhat plugin HOT 8
- Codecov result don't show up in the PR summary anymore
- Incorrect link formatting in NatSpec causing broken URLs HOT 2
- Consider making `Votes._moveDelegateVotes` internal virtual
- Consider using transient storage in Governor and AccessManager HOT 1
- Incorrect pragma
- bugs in the docs code? ERC721 HOT 1
- AccessManager restricted should not default to admin role HOT 1
- Mark AccessManagerUpgradeable abstract or implement initializer function HOT 1
- Fix API documentation broken links in the doc-site
- Make `_moveDelegateVotes` internal in Votes.sol HOT 1
- Request to Add Upgradable Interfaces in contracts/interfaces Directory of the OpenZeppelin Contracts Upgradeable Repository HOT 2
- Semi abstracted nonce support
- Low level call library HOT 3
- UUPSUpgradeable is not ERC1882 (draft) compatible, but rather only ERC1967 compatible. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openzeppelin-contracts.